JonnyJD / musicbrainz-isrcsubmit

script to submit ISRCs from disc to musicbrainz
http://jonnyjd.github.io/musicbrainz-isrcsubmit/
GNU General Public License v3.0
40 stars 13 forks source link

removing backends in isrcsubmit2 #48

Open JonnyJD opened 11 years ago

JonnyJD commented 11 years ago

The original idea was to drop backends completely and use libdiscid ISRC support.

However, I think libdiscid 0.3.2 won't be in openSUSE 12.3 and also not in Ubunut 13.04. This means, that many Linux users probably won't have a libdiscid version that supports ISRC reads (without using backports).

So we might drop only backends that only work in Windows and Mac OS X, since for these packages we ship libdiscid anyways. Might keep supporting mediatools until libdiscid fixes metabrainz/libdiscid#6

Not sure if that makes sense anyways, since python-discid also won't be in the repos and we WILL use python-discid because python-musicbrainz2 doesn't work with Python 3.

So we might drop backends anyways.

(Feedback welcome)

EDIT: It is already planned to maintain isrcsubmit1 for a while. At least until the dependencies of isrcsubmit2 are somewhat available. We might also provide a backport PPA for libdiscid on some ubuntu releases.

Freso commented 11 years ago

Personally, I think you might as well depend solely on libdiscid for future releases. Non-rolling releases likely won't update to 0.4.0/1.0 right away anyway, and may just as well pull in libdiscid when they do.

JonnyJD commented 11 years ago

Well, but currently there are two features that are still only available with other backends:

  1. LIB-11 raw ISRCs (somewhat rare)
  2. LIB-25 ISRCs in CD-TEXT (rare)

That means I would keep cdrdao (CD-TEXT) and mediatools (raw ISRCs) at least in the beta releases. When these features are implemented in libdiscid, I could drop the backends. Possibly that happens before the 2.0.0 release.

Being implemented and released in libdiscid is enough though. I don't need for the changes to propagate to distributions for the reasons you stated. On Windows and Mac OS X I provide complete packages anyways.

jesus2099 commented 8 years ago

LIB-11 from #5791, called raw ISRC, is not that rare, in my experience: