search

Jonnyauk / Wonderflux

A free, professional Open Source theme framework for WordPress & BuddyPress. Download the latest stable release by clicking on the 'releases' tab. API documentation at http://wonderflux.com/guide or drop by the main site at
http://wonderflux.com
159 stars 46 forks source link

Add case-insensitive string comparison for $last and $divoutput paramete... #25

Closed rikanio closed 11 years ago

rikanio commented 11 years ago

...rs - allows 'y' or 'Y' to be passed and still work!

Found an issue where the 'last' css class was not being added to the sidebar div when specifying the sidebar to be on the right, causing it to drop down beneath the content. The call to wf_css was passing 'y' whereas 'Y' was expected!

Noticed that the option for $divoutput may also hit the same problem, so changed that one too!

Cheers, Rik

Jonnyauk commented 11 years ago

Thanks for the pull request, appreciated! It would catch an error when people pass 'y' instead of 'Y' as a param. I use Y and N quite a-lot, so this should probably be deployed as a safety catch in a-lot of circumstances!

rikanio commented 11 years ago

No probs - having fallen into that trap more times than I really should over the years, I seem to be attuned to string case irregularities! ;)

If I spot anything else, would you prefer an issue raised, or a random pull request...?

Jonnyauk commented 11 years ago

Whatever works best for you - pull request is fine or raise issue - I don't mind ;)