JonsonJunSheng / RShinyTraining

0 stars 0 forks source link

Feedback on R shiny app #1

Open jonekeat opened 2 years ago

jonekeat commented 2 years ago

Hi Johnson, thanks for attempting the shiny assessment, please find my feedbacks below:

  1. As indicated in original excel template, Amount of Claims Paid by development year & loss year should be input by users. Although in the R code, it reads claim data from excel file, but once deployed to shinyapps.io, user will not able to change the claims data. Therefore, you should allow user to upload file instead. PS: This read values from file method only suitable for reading constant values before app rendered image

  2. About graph, since claims amount is currency value, we should put thousand separator in the values. The x-axis should only should integer values (remove 1.5, 2.5, 3.5,...) image

  3. Table formatting can be improved, eg nested column headers & cell color based on whether it is projected / experience data. You may consider using DT for interactive table or gt

debbiemj commented 2 years ago

Hi @JohnsonJunSheng, thanks for completing the assignment.

In addition to Jone Keat's comments above, I would suggest you using R shiny dashboard from the shinydashboard R package as the UI template of your app (instead of just fluidPage). This is the standard UI template we usually use in developing R shiny apps.

FYI we are currently exploring the more advanced app UI template from the shiny.fluent R package and have already implemented it in our latest app development, so it would be useful if you could get yourself familiar with the standard shinydashboard package first.