JonsonJunSheng / RShinyTraining

0 stars 0 forks source link

Correction1 #2

Closed JonsonJunSheng closed 2 years ago

jonekeat commented 2 years ago

@JohnsonJunSheng Great work, I have review the app and saw good improvement in UI, below is my feedbacks:

  1. Performance of the app: after I uploaded the csv file, the preview table beside pop out quite fast, but when I navigate to "Simulating" tab, the graph & table spent around 5-6 second to render, which I think the wait time is unreasonable, since we dont have large data & complicated calculation.

For improvement, you may google some performance tips for R programming, & shiny, here is my recommendations:

  1. Graph & table UI look, I think the table can be design nicer, eg, thousand separator & column names image image

For graph, maybe the y-axis can be formatted? image

Other than that, i think the rest are good!

jonekeat commented 2 years ago

You may proceed to merge this PR 🚀