Jontes-Tech / floopr

Everyone's Loop Library, free as in freedom!
https://floopr.org
2 stars 0 forks source link

Pictures instead of links in the loops page #7

Closed Chriffe closed 1 year ago

Chriffe commented 1 year ago

I would really like to have some pictures instead of the links on the loops page. The first picture is a suggestion on how I think it should look with slightly rounded corners. And I also would like to have them displayed like this in a grid.

layout-icons

The pictures: bass drums guitar keys

Will add more pictures in the future, but let us start here for now.

Jontes-Tech commented 1 year ago

The problem is just when someone creates a new category they would need to make a similar image.

Chriffe commented 1 year ago

Yes, but since I will be moderating, I can make new images, and or change category for the loop.

Chriffe commented 1 year ago

Two more pictures/categories. I will not be doing anymore now until I see a need.

orchestral fx

Jontes-Tech commented 1 year ago

We'll have to add a step so people click "allow modifications from contributors" then

Chriffe commented 1 year ago

What do you mean?

Here is another category. Last one for now. Promise. vocals

Jontes-Tech commented 1 year ago

I am thinking if we should just do a regular old form and then we populated the repo bypassing PRs but adding more work, or if we should keep the current workflow or if we should use a Hugo "CMS"-style frontend

Jontes-Tech commented 1 year ago

Implemented the images, but for some reason only drums is displaying. Looking into this.

Chriffe commented 1 year ago

Nice! Really like how the picture grows when you hover over.

However... there are som pretty nasty compression artefacts. Have you compressed the image for optimization purposes? If so, maybe we should make the picture smaller, so that it hopefully won´t be as noticeable.

Jontes-Tech commented 1 year ago

Yes, I did compress the images. Maybe we could either make them smaller or I could just compress them less.

Jontes-Tech commented 1 year ago

fixed, and works in prod. Closing.