search

JonyEpsilon / gorilla-repl

A rich REPL for Clojure in the notebook style.
http://gorilla-repl.org
MIT License
887 stars 104 forks source link

Should reset nREPL session when loading or resetting worksheet #127

Open JonyEpsilon opened 10 years ago

JonyEpsilon commented 10 years ago

Not doing this results in some unexpected behaviour with namespaces. The user might think it should be bound to the worksheet, but at the moment it's actually bound to the browser tab. This means it feels a bit odd when you load or reset from a worksheet that had changed namespace.

jaredly commented 10 years ago

(sorry I posted this in the wrong issue the first time) What would this entail? Would we need to create a new websocket, or is there an op for get a clean session?

JonyEpsilon commented 10 years ago

There's an op to get a new session (clone). What needs cleaning up is the way that connect/disconnect happens with the websocket. It also would be good at the same time to resolve the connection/client/session confusion that's making interrupt #18 fail.