worksheets saved without .clj won't load back in

[lspector]

I do this:

• create a worksheet and evaluate a couple of expressions
• do ctrl+g ctrl+s to save it
• see the file in the top level of the project directory, and a message in the console
• add some new expressions to the worksheet but don't save them
• do ctrl+g ctrl+l to try to load the saved worksheet, providing the same name in the name field

This seems to work (it reverts to the saved state) if the name ends in .clj, but to fail silently otherwise (no message in the console.

[JonyEpsilon]

Aha, so this isn't a bug, it's just the user interface misleading you to the extent that you think it's not working :-)

The idea with the load box (and the command box, which is the same) is that the list of possible options is shown below, and the text box is a filter. But you're not the first person to think it was a free text input (and quite reasonably at that), so I'd say the UI there isn't doing its job. It's doing what was intended, as in it's filtering the list down to zero when you type in the filename. It doesn't help that pressing enter when the list is filtered to zero closes the dialog, which would give the impression that something had succeeded!

The reason the list is empty in the first place is that Gorilla only considers files that either end in ".cljw" or end in ".clj" and have the magic header. It could be argued as well, that this is an unnecessary restriction.

I'll take a look at the UI and think about the file name requirements to try and make this a bit more obvious.

[bherrmann7]

I tried out gorllia today. I think it is pretty awesome, however when I went to save my worksheet, I chose the name "Bobs-Nice-Tinkering" and then I wasnt able to load the worksheek back. Even though I typed the name correctly. So then I created and saved worksheets "x", "b", "c"... also couldnt load them no matter what (and never showed up in the load list.)

I finally downloaded the source and built locally. Only then when the open workspace dialog showed a "test.clj" file - did it dawn on me that perhaps the worksheets need to be saved with .clj

I thought gorrllia was pretty broken until I realized this.

I think either it should allow worksheets to be saved/loaded with any name. Or it should strongly encourage saving with the proper extension.

Of course, I should submit a patch... and I should appreciate all the things that are nice and wonderful.

[dasmoth]

I've just run into this issue as well (think I've missed it in the past because I've tended to just manuall create ?filename=foo URLs). Like @bherrmann7 I think that encouraging the use of a suitable extension in the Save box would be a big help.

[JonyEpsilon]

Yeah, this is a bit of a mess at the moment. I think the best thing right now would probably be to remove the restriction on the filename when loading. I'm currently pondering changing the UI for load/save a bit, so I don't think we should do too much just now.

[benfb]

This should be fixed in the next release, at least to some extent. .clj is prepopulated in the save dialog.