Closed k4y3ff closed 1 year ago
Hi, just a quick ping as am on my hols at the moment! Will have a proper look once I'm back :-)
Hi Katherine,
sorry once again for being so slow on getting back to you on this!
Looks good to me, on the whole. A few comments:
self.activate
to avoid showing the editor altogether. Pretty much calling only self.active(true);
would do it I think. I haven't tried this, though, so there might be some problems that I'm not seeing. The segment's active
property should be the only thing that's needed to make the segment 'cursor' (the pink outline) and the targeting of commands work.lockedTag
in the parser to be ;; {locked: true}
. Or, I wonder whether we could even put the JSON data on the same line as the segment open tag ;; **
to keep the extra comment lines to a minimum?But, yes, looks good, and will be a good feature I think :-)
Jony
Hi, Jony! :wave:
I was reading #193 and decided to give it a go! So, I wrote a draft! And this is a WIP PR. Do not merge; do not pass GO, do not collect $200; etc.
Current functionality:
I'm running into one current, obvious problem, though, which I'm hoping you'll have some input on:
I've tried various ways to get around this, especially by just having
self.lock
insegment.js
setself.markupVisible(false);
so long asself.locked() == true
. But, when I tried that approach, specifically, I ran into the problem of redefiningactivate
anddeactivate
for locked segments, which was... yargh. Becauseactivate
anddeactivate
currently involve CodeMirror cursors.Anyway, thoughts? Advice?