search

JonyEpsilon / gorilla-repl

A rich REPL for Clojure in the notebook style.
http://gorilla-repl.org
MIT License
887 stars 104 forks source link

Can't exit command menu via keyboard #212

Closed spieden closed 7 years ago

spieden commented 9 years ago

With the command menu open (ctrl+g ctrl+g), there doesn't seem to be a way to exit it via the keyboard. i.e. You can click outside of it to exit, but I'd expect "esc" or another "ctrl+g ctrl+g" to close it as well.

JonyEpsilon commented 9 years ago

Esc should close the menu (and does on my machine). Could you share your OS and browser version so we can try and track down the problem?

spieden commented 9 years ago

Ah, I bet it's Vimium that's trapping the escape key. That always gets me https://github.com/philc/vimium/issues/239

What do you think about a second cntrl+g cntrl+g closing the menu if it's already open?

JonyEpsilon commented 9 years ago

Yes, that sounds like a natural way to do it.

benfb commented 7 years ago

Looks like this was fixed in vimium a while ago.