search

JonyEpsilon / gorilla-repl

A rich REPL for Clojure in the notebook style.
http://gorilla-repl.org
MIT License
887 stars 104 forks source link

Separated nrepl code, added CLI options, added failover #220

Open chrisbetz opened 9 years ago

chrisbetz commented 9 years ago

Hi,

I'm not sure whether you're interested in this sort of changes or not, so feel free to just drop this PR. But for my use-case (combining GorillaREPL with ApacheSpark) it's really important, so it might be interesting for others. Main rational is I needed to avoid dependency conflicts.

Here's what I did:

Feel free to take whatever is necessary and wanted and be assured that I find GorillaREPL a really cool project!

Cheers,

Chris

This change is Reviewable

JonyEpsilon commented 9 years ago

Hi Chris,

thanks, this is great :-) That is a feature I'd really like to get into the next release (see #137). I should have time in a few weeks to sit down and put a release together, so will return to this PR then.

Thanks again,

Jony

chrisbetz commented 9 years ago

Oh, you're welcome. Didn't see that discussion before ;)

Just take your time!

On Tue, Jun 30, 2015 at 12:35 PM, Jony Hudson notifications@github.com wrote:

Hi Chris,

thanks, this is great :-) That is a feature I'd really like to get into the next release (see #137 https://github.com/JonyEpsilon/gorilla-repl/issues/137). I should have time in a few weeks to sit down and put a release together, so will return to this PR then.

Thanks again,

Jony

— Reply to this email directly or view it on GitHub https://github.com/JonyEpsilon/gorilla-repl/pull/220#issuecomment-117118269 .

JonyEpsilon commented 9 years ago

There's a broader discussion that might be of some interest too, thinking about what the relationship should be between nREPL, Gorilla etc. It's at #184 in case you'd like to look :-)