allow port file specification in config

JonyEpsilon / gorilla-repl

A rich REPL for Clojure in the notebook style.

http://gorilla-repl.org

MIT License

888 stars 104 forks source link

allow port file specification in config #233

Closed mattexx closed 8 years ago

JonyEpsilon commented 8 years ago

Looks good. I wonder, though, are we immediately going to run into the same problem with the .gorilla-port file that is also written out, indicating to tools the port on which gorilla's web interface is running. Maybe it makes sense to make that configurable here as well?

mattexx commented 8 years ago

You got it!

JonyEpsilon commented 8 years ago

Thanks :-)

I made a small change, which was to take file paths rather than File objects in the configuration, as it seems more naturally clojure-y. Let me know if this causes problems for your application and we can change it back if so. See https://github.com/JonyEpsilon/gorilla-repl/commit/5e5e8a359a696b7f5445ed6e09bf0a892db60336