search

JonyEpsilon / gorilla-repl

A rich REPL for Clojure in the notebook style.
http://gorilla-repl.org
MIT License
887 stars 104 forks source link

No errors/feedback for save errors #271

Open lspector opened 7 years ago

lspector commented 7 years ago

Saving to an invalid path, and maybe other errors currently fail silently.

MawiraIke commented 4 years ago

Hello @benfb . Thanks for maintaining the awesome library, I totally enjoy using it. I got some time in my hands and would like to contribute to the library and work on some fixes. This issue seems like a good starting point for me, 1) are you still open to a PR concerning the same? 2) I can see that the current code throws a common alert for every error, i.e Failed to save worksheet. Did you intend to show different errors according to the error thrown e.g File not found etc.

Again, thanks for the library. Regards, Ike.