Closed shriphani closed 10 years ago
Hi Shriphani, I've finally had a chance to start looking at this PR, and just wanted to update you on where I'm at. I've been doing a bit of tweaking, to try and make the generated HTML files a bit smaller. But in doing so, I've had an idea for a different way of doing it: using phantomjs to render the page in javascript, and exporting that. This would be nice because then the page could be really static (i.e. the graphs would already be rendered to SVG etc), and it would re-use the javascript parser and viewer code, meaning less code to maintain.
I'm planning to play around with that idea to see whether it really is better. I think it will be though. So I'm going to hold off merging this PR into develop for the moment, pending what I find with the phantomjs experiment. Hope that's ok with you - sorry not to merge it straight in - but I think it's worth a little time to make sure we're doing it in the best way possible :-)
Sure. let me know how the experiment goes.
Haven't had much time to work on it lately, but it looks like the PhantomJS approach is going to work nicely, and gives truly static HTML, with the graphs etc pre-rendered. So, let's close the PR. Thanks, though for all of your work on it - it really helped clear up the different ways of doing it.
So is it possible right now to export worksheet into HTML? I didn't see that in the docs.
You can save the file with your browser afaik.
Fixes: https://github.com/JonyEpsilon/gorilla-repl/issues/7