search

Joolee / nl.joolee.homey.espeasy

ESP Easy is a firmware for ESP8266 boards like the WeMos D1 and NodeMCU. It allows you to quickly make custom devices with switches, sensors and other hardware. This app adds support to Homey for connecting with ESP Easy units.
GNU General Public License v3.0
6 stars 5 forks source link

Change all require() paths to relative #40

Open roelofoomen opened 1 year ago

roelofoomen commented 1 year ago

As described in the developer guide.

roelofoomen commented 1 year ago

With these changes the app seems to run fine on my Homey Pro 2023.

Joolee commented 1 year ago

The app has been updated far enough now that it will start without immediately running into a problem but I still had the app crashing on my 2016 Homey after running for a while. Also haven't tested actually doing anything with the app yet like adding or removing devices, receiving events and changing settings. I still expect there to be a lot of crashes testing that, that's why I haven't released anything yet.

About your patch; seems to be a 2023 Homey thing, needing relative paths. I can't test that as I don't have the new model but I'll assume it's necessary :) Unfortunately, your autoformatting plugin had made thousands of changes throughout the codebase. Can you change the patch to only include the actually functional code chances?

roelofoomen commented 1 year ago

Oh, indeed, I didn't notice all the formatting changes, I'm sorry. I'll fix this and resubmit.

I'm running the app currently with one Wemos D1 Mini connected and it seems stable and working for this single case. This was a device that was added already using the previous version of the app on my Homey Pro 2019 (I restored a backup to my new Homey), so I haven't tested adding devices and ports etc.

roelofoomen commented 1 year ago

I fixed the PR. All formatting changes have been removed.

roelofoomen commented 7 months ago

I've been using this version since June now, with one ESP device (Wemos D1 Mini) with 5 GPIO Pulse Outputs, without noticing any issues.