search

JoomFish / joomfish-2.5

Joom!Fish 2.5 core development
http://www.joomfish.net/
34 stars 27 forks source link

K2 Extra Fields Translation not stored #127

Open harrybevers opened 11 years ago

harrybevers commented 11 years ago

Schermafbeelding 2013-01-21 om 10 38 41 The translation of the extra field label in K2 items is not being stored. From original: Original [{"id":"1","value":"2"}]
Only {[ is stored in the translation.

akempkens commented 11 years ago

Does the K2 version you use support JoomFish 2.5 already? I know that in the past they integrated some special code to work with JoomFish

2013/1/21 harrybevers notifications@github.com

[image: Schermafbeelding 2013-01-21 om 10 38 41]https://f.cloud.github.com/assets/1586304/82530/9a1d0fa2-63ae-11e2-8534-665f01761b34.png The translation of the extra field label in K2 items is not being stored. From original: Original [{"id":"1","value":"2"}]

Only {[ is stored in the translation.

— Reply to this email directly or view it on GitHubhttps://github.com/JoomFish/jf-future/issues/127.

harrybevers commented 11 years ago

Hello Alex,

After posting and reading this: http://www.joomfish.net/forum/viewtopic.php?f=48&t=11732 I assumed support of K2 was working. However, reading your question makes me wonder if it is really so. I already did post a question http://getk2.org/community/New-to-K2-Ask-here-first/167662-Joomfish-25-for-Joomla-25-and-K2 but nobody has answered yet. I suppose there is no contact between JF developers and K2 developers, otherwise you would know. What is the best way to handle this, because both JF and K2 are major applications for me.

Regards,

Harry

akempkens commented 11 years ago

Hi Harry,

The teams do have contacts sometimes. It isn't that easy to fix as the storage of extra fields is something quite complex. Let us check as well and with both of your links we have a good chance to improve both extensions.

2013/1/21 harrybevers notifications@github.com

Hello Alex,

After posting and reading this: http://www.joomfish.net/forum/viewtopic.php?f=48&t=11732 I assumed support of K2 was working. However, reading your question makes me wonder if it is really so. I already did post a question http://getk2.org/community/New-to-K2-Ask-here-first/167662-Joomfish-25-for-Joomla-25-and-K2but nobody has answered yet. I suppose there is no contact between JF developers and K2 developers, otherwise you would know. What is the best way to handle this, because both JF and K2 are major applications for me.

Regards,

Harry

— Reply to this email directly or view it on GitHubhttps://github.com/JoomFish/jf-future/issues/127#issuecomment-12495798.

harrybevers commented 11 years ago

Hello Alex,

Good news: “If you didn't know already, Joom!Fish is http://www.joomfish.net/en/news/247-joomfish-250-stable-release-for-club-members now available for Joomla! 2.5 or newer (good news!) and we've adapted K2 to be fully compatible with this new release.”

http://getk2.org/blog/item/1145-k2-v263-released-new-performance-improvements http://getk2.org/blog/item/1145-k2-v263-released-new-performance-improvements

Best regards,

Harry

Van: Alex Kempkens [mailto:notifications@github.com] Verzonden: maandag 21 januari 2013 13:35 Aan: JoomFish/jf-future CC: harrybevers Onderwerp: Re: [jf-future] K2 Extra Fields Translation not stored (#127)

Hi Harry,

The teams do have contacts sometimes. It isn't that easy to fix as the storage of extra fields is something quite complex. Let us check as well and with both of your links we have a good chance to improve both extensions.

2013/1/21 harrybevers < mailto:notifications@github.com notifications@github.com>

Hello Alex,

After posting and reading this: http://www.joomfish.net/forum/viewtopic.php?f=48&t=11732 http://www.joomfish.net/forum/viewtopic.php?f=48&t=11732 I assumed support of K2 was working. However, reading your question makes me wonder if it is really so. I already did post a question http://getk2.org/community/New-to-K2-Ask-here-first/167662-Joomfish-25-for-Joomla-25-and-K2but http://getk2.org/community/New-to-K2-Ask-here-first/167662-Joomfish-25-for-Joomla-25-and-K2but nobody has answered yet. I suppose there is no contact between JF developers and K2 developers, otherwise you would know. What is the best way to handle this, because both JF and K2 are major applications for me.

Regards,

Harry

— Reply to this email directly or view it on GitHub< https://github.com/JoomFish/jf-future/issues/127#issuecomment-12495798 https://github.com/JoomFish/jf-future/issues/127#issuecomment-12495798>.

— Reply to this email directly or view it on GitHub https://github.com/JoomFish/jf-future/issues/127#issuecomment-12495934 .

https://github.com/notifications/beacon/X7lAL7E9HoLE0rSt-iS2SZJ5ceUMBN8l3sP-1BFZwDZgyW9bB0rTRuSMTYTPgU09.gif

harrybevers commented 11 years ago

K2 is fully compatible, all is working, except the issue of the storage of the Extra Fields, as described in my first message.

harrybevers commented 11 years ago

Hello,

This problem is, as far as i can see, unsolved. Also no comments from Joomlaworks. An change of Solution or Workaround?

Harry

StVak commented 11 years ago

Same problem here, any solution found?

harrybevers commented 11 years ago

Ik ben afwezig t/m 19 juli. Vanaf 17 juli kan ik uw e-mail weer beantwoorden. Vriendelijk groet,

Harry Bevers BCMI Leeuwarden

batfich commented 11 years ago

Hello,

It is the solution of the problem: http://code.google.com/p/getk2/issues/detail?id=491 Make change in: yourhomedir/plugins/system/k2/k2.php

Regards, Nikolay Tachev

antoniocici commented 10 years ago

Hello,

I think I've found the needle. In fact, I've solved the problem and now it works properly on my website.

The problem is inside the view, and only there. When the value is echoed, it contains double quotes, and here comes the struggle:

<input class="inputbox" type="text" name="refField_<?php echo $field->Name;?>" size="<?php echo $length;?>" value="<?php echo $translationContent->value; ?>" "<?php echo $maxLength;?>"/>

so the browser, at the first occurrency of " into the value, close the property, trunking the value.

What is the solution? Changing double quotes with a single quote at the row 272 of the /views/translate/tmpl/edit.php file as follow:

<input class="inputbox" type="text" name="refField_<?php echo $field->Name;?>" size="<?php echo $length;?>" value='<?php echo $translationContent->value; ?>' "<?php echo $maxLength;?>"/>

Just a small change :)

I've still a little problem with multiple extra fields, that are not correctly displayed into the front end side, but I hope to solve also that problem soon.

I hope that this solution can be helpful to someone else.

Antonio Cicirelli