search

JoomFish / joomfish-2.5

Joom!Fish 2.5 core development
http://www.joomfish.net/
34 stars 27 forks source link

TranslationFilter in content.xml #15

Closed MStruller closed 12 years ago

MStruller commented 12 years ago

in content.xml there are three filters

state state state

all the filters have the same based field 'state' and i think this can have curios results in the query we can have 'c.state = 1 AND c.state >= -1 AND c.state = 0' so the query will not have an corect result.

I think better use only another filter (named state) where we have all from FilterPublished and archive and trash and one change Archived state changed from a value of -1 to +2 (see http://docs.joomla.org/What%27s_new_in_Joomla_1.6)

MStruller commented 12 years ago

Oh i see 'Filter published' is for 'Translation Availability' but by work on 'native' the published is for 'content' in the #content table not in the #jf_content table

klas commented 12 years ago

Technically this is ok, but from UI standpoint having separate archive filter is questionable as this states are now unified in joomla UI