JoomFish / joomfish-2.5

Joom!Fish 2.5 core development
http://www.joomfish.net/
34 stars 27 forks source link

Language specific "System Configuration" is not saved (i.e. offline message) #52

Open quodo opened 12 years ago

quodo commented 12 years ago

Language specific "System Configuration" is not saved (i.e. offline message, Global Site Meta Description, Global Site Meta Keywords, etc.).

Reproduce

Where should this be saved in the database?

Joomla 2.5.3, PHP 5.2.9, MySQL 5.1.33, Mozilla Firefox JoomFish jf-future with latest commit 4821ac0986

klas commented 12 years ago

Note: you need to save or apply again, after you have already clicked save&close in popup. At least we need to change this misleading language in popup.

quodo commented 12 years ago

I'm happy with this, although there are a few minor things left.

Test scenario and results The JoomFish Language Manager, in my case, shows three languages: en-GB (default language, english), nl-NL (dutch) and de-DE (german). For each language there is a "Config button" that shows a screen with

Settings are saved for the non-default languages nl-NL and de-DE, not for the default en-GB. However, although the settings for the default language seem not to be saved, the Global Site Meta Description and Global Site Meta Keywords are taken from the last attempt to save it. In phpMyAdmin I can see that the metakey and metadesc (and sitename) are saved in table jos_languages.

I have only two languages in jos_jf_languages_ext: the non-default ones: nl-NL (lang_id 2) and de-DE (lang_id 3). Is this correct or something wrong with my installation? Does it have anything to do with the empty "System configuration" popup screen for the default language?

PHP 5.2.9

Minor issues/questions left

akempkens commented 11 years ago

It seems there is an unrelated issue with the first installed language. The extended table row is not created all the times.

The label within the box is changed.