Globally calculated parameter in edit views

[Elfangor93]

This PR adds the global calculated parameter in the Parameters tab of the "Edit Image" and "Edit Category" view. The dynamic calculation of the global parameter is done with the same logic which will later be applied but without taking into account parameters set by the Menu Item. In addition, the parameters are carried out on the basis of the current user. Therefore the calculated value can change based on the user group you are in...

[eumel1602]

If I click on the two links: Configuration inheritance and Configuration Set in an image or category, the respective setting options are shown in the same window. If I then change something there and save it, I come back to the main overview (images or category). The edited image/category is then locked with a lock. This could no longer allow users without superadmin rights to edit the image? Wouldn't it be better if the two links open a modal window and after changing the settings you are back at the selected image/category?

(Otherwise the PR shouldn't do anything except the link, right?) sorry for always asking questions like this, but unfortunately it doesn't explain what to do here...

[Elfangor93]

No, the new functionality is the value in brackets

Based on the chosen Configuration inheritance method and your settings in the configuration sets, this value in brackets gets calculated and is then shown.

In the example above with the watermark means that no dynamic watermark will be shown for this image in the frontend for the current user. You can now override this setting parameter by chosing "Yes" to force to show a dynamic watermark for this very image.

[Elfangor93]

If I click on the two links: Configuration inheritance and Configuration Set in an image or category, the respective setting options are shown in the same window. If I then change something there and save it, I come back to the main overview (images or category). The edited image/category is then locked with a lock.

I can not confirm that. Can you please provide step by step how to reproduce this issue?

[MrMusic]

If I click on the two links: Configuration inheritance and Configuration Set in an image or category, the respective setting options are shown in the same window. If I then change something there and save it, I come back to the main overview (images or category). The edited image/category is then locked with a lock.

I can not confirm that. Can you please provide step by step how to reproduce this issue?

If you are in the parameters tab and click on one of the two links in the description , the currently edited category remains as "Checked out". Recommendation: remove the link.

I have only tested categories:

For me, the displayed value does not correspond to the value from the configuration but to the last saved setting of the respective category. Example: The setting for Allow Rating in the configuration is 'Yes'. Open a category, display for Allow Rating is "Use Global (Yes)" ->Correct. Change the setting to 'No' and save the category. Now Display for Allow Rating is "Use Global (No) ->Wrong

In addition, some of the parameters no longer make sense, as some things have changed in comparison to JoomGallery 3.

Allow Rating - Yes, you can adopt this 1:1.

Add Watermark -This refers to the 'dynamic' watermark or 'fixed' watermark or both? -There is now a separate option to set the watermark for each image type. Which image type should be used for "Use Global"? Should the value set in the category override the setting for all image types?

Offer Downloads - Yes, you can adopt this 1:1.

Download with Watermark -Same problem as with Add watermark

The display would have to be adapted somewhat, currently it is difficult to see which value is selected, see screenshot.

[Elfangor93]

In addition, some of the parameters no longer make sense, as some things have changed in comparison to JoomGallery 3.

Yes, you are right. Maybe we should discuss this in our next online meeting.

We have now the possibility to override parameters on ...

• ... categories (they will apply for all images and sub-categories of this category)
• ... images (they will apply specifically for this image)
• ... menu item (they will apply for all images and categories displayed within the view of this menu item)

But I would like to merge this PR anyway and change/switch the parameters afterwards in another PR.

[reilldesign]

A little late, but still important. To ensure a consistent user experience a standard display with the Joomla dropdown solution would be desirable (screenshot).

[Elfangor93]

A little late, but still important. To ensure a consistent user experience a standard display with the Joomla dropdown solution would be desirable (screenshot).

If the other agree with @reilldesign to use a dropdown field instead of the currently used buttons then please open a separate issue for that. This change will produce a rat tail of changes and can be improved in a later time.

[AlexanderSupp]

There are some confusing blemishes. I will put these together when we have achieved a first degree of completion of the most important functions. I agree with @reilldesign.

[Elfangor93]

@reilldesign Since this is an enhancement and high priority I added an issue for your request to discuss and implement that later on. See issue #112

[MrMusic]

I think the shown global calculated parameter is still wrong. @Elfangor93 Did you take a look at my code reviews?

[Elfangor93]

Did you take a look at my code reviews?

@MrMusic No, where can I find them?

[MrMusic]

No, where can I find them?

Here after the contribution by reilldesign. But it's only displayed when I'm logged in :confused:. Not to you?

[Elfangor93]

No its not visibla to me. Have you pressed the button "Finish your review" after you added your comments to the code? If you dont finish your review, the comments are only visible to you...

[MrMusic]

If you dont finish your review, the comments are only visible to you...

Thanks! I have misunderstood this.

[MrMusic]

Parameters are good now. Thanks. Design is discussed here. I have tested this item ✅ successfully. Thank you very much.