search

JoomGalleryfriends / JG4-dev

Development repository for JoomGallery v4.x
GNU General Public License v3.0
10 stars 6 forks source link

Replace imagetype #110

Closed Elfangor93 closed 1 year ago

Elfangor93 commented 1 year ago

This PR adds the functionality to replace/exchange a specific imagetype (thumbnail, detail, original, ...). This is useful for example, if you are not satisfied with an automatic processing result and you want to create the image for this imagetype locally by hand and then replace it. In the Image edit view there is now a "Replace" button in the preview modal of each imagetype. This button brings you to a from view where you can select/upload the image used for replacement. grafik

Replacement form view grafik The left side is to be filled out. The right side gives you the info on which image you are working on.

AlexanderSupp commented 1 year ago

I miss a close button here. Screenshot 2023-06-19 013722

MrMusic commented 1 year ago

It looks good to me. Only the following PHP warning appears during the replacement: PHP Warning: Undefined array key "filename" in ...administrator/components/com_joomgallery/src/Service/Uploader/SingleUploader.php on line 117

MrMusic commented 1 year ago

It would now be ready to merge. @Elfangor93 can you clean up the conflicting files?

MrMusic commented 1 year ago

I have tested this item ✅ successfully. Thank you very much.