search

JoomGalleryfriends / JG4-dev

Development repository for JoomGallery v4.x
GNU General Public License v3.0
10 stars 6 forks source link

[IMGtools Service]: Image file size doubles on upload #118

Open mastervanleeuwen opened 1 year ago

mastervanleeuwen commented 1 year ago

Hi,

I have started trying out JG4 and found that when I upload a photo that originally is about 5 MB, the file that is stored in the 'originals' directory is more than 10 MB large. This also causes some confusion with the upload size limit: I got a warning that the file that I was uploading was too large, since it grew to over 10 MB in the upload process.

I dug through the code a bit to try and understand where the warning came from. From what I have seen so far, it looks like the max file size is actually determined by settings of the media component: the code uses the MediaHelper, which takes the settings from 'com_media'; increasing that limit to 15 MB allowed me to upload the picture, while the size limit in JoomGallery was still indicating 10 MB. For reference: this is where the max file size is retrieved and checked: https://github.com/joomla/joomla-cms/blob/6a1a72ab25fd0722c9b4be2474a67dbe877d2585/libraries/src/Helper/MediaHelper.php#L262 $params are the settings for 'com_media' (l210 in the same file)

Let me know if you need more details to follow up on this.

Best regards, Marco.

MrMusic commented 1 year ago

Hi Marco,

yes, I can recognise your problem. The file size can change when the image is recompressed. Depending on the strength of the compression, the file size may be larger than before. The allowed file size for the upload is set in the Joomla Media Manager. In the JoomGallery Configuration Manager, the corresponding size is currently displayed in the 'Common Settings' tab.

Elfangor93 commented 1 year ago

I think this is due to the fact that the original image gets passed through the image processor even if there are no image manipulations configured in the configurations.

@mastervanleeuwen Do you see this behaviour for both image processors (GD and ImageMagick)?