JoomGalleryfriends / JG4-dev

Development repository for JoomGallery v4.x
GNU General Public License v3.0
10 stars 6 forks source link

Use 'Admin approval' setting for uploads #121

Closed MrMusic closed 1 year ago

MrMusic commented 1 year ago

Actual result: So far all uploaded images are automatically not approved.

Changes: Move and activate the option 'Admin approval' to the configuration tab 'General Settings -> Uploads'. Modification of the language string. Consider the setting for the uploads.

Expected result: Depending on the setting in the configuration, the images are automatically approved or not when uploaded.

reni68 commented 1 year ago

It works. Image in Cat-A with Admin approval and Image in Cat-B ohne Admin approval in the configuration. grafik

PS: Multiple Upload is not working here.

MrMusic commented 1 year ago

Thank you for testing.

PS: Multiple Upload is not working here.

That is correct, as this is contained in a separate pull request. Unfortunately, this has not been merged yet. Since the change only affects a single line, you can make the change yourself if necessary.

rowi68 commented 1 year ago

Hello everyone, just finished my first test... :-)

So it works for me on a subdomain..., cycling

....but I can't save images local. I don't know, perhaps a configuration issue with Xampp? (I use Xampp first time) unsupported_image-filetyp

AlexanderSupp commented 1 year ago

@rowi68 ....but I can't save images local. I don't know, perhaps a configuration issue with Xampp? (I use Xampp first time)

Please check in Joomla Content, Media, Options, Allowed Extensions and Legal Image Extensions, and also JoomGallery, Configuration Sets, Supported image types Maybe you use a jpEg-file and only jpg is defined.

rowi68 commented 1 year ago

Hello Alex,

Thank you for advices. I could not find the reason. All file types like jpg,jpeg,png,gif,webp are defined and allowed, but non of them are storable. Because it works on my subdomain, I will continue testing there in future....

MrMusic commented 1 year ago

....but I can't save images local. I don't know, perhaps a configuration issue with Xampp? (I use Xampp first time)

@rowi68 thanks for testing. If you are using Xampp for the first time, the GD extension is probably not activated. You have to activate it in php.ini. Check which GD version is displayed in the JoomGallery configuration.

rowi68 commented 1 year ago

@MrMusic This was the cause. Now it works. Thanks for help....

Elfangor93 commented 1 year ago

I tested this PR successfully. Tank you very much!