search

JoomGalleryfriends / JG4-dev

Development repository for JoomGallery v4.x
GNU General Public License v3.0
10 stars 6 forks source link

Fix error during uninstallation #128

Closed MrMusic closed 1 year ago

MrMusic commented 1 year ago

Fix for issue https://github.com/JoomGalleryfriends/JG4-dev/issues/127

Thanks for reporting this.

reni68 commented 1 year ago

I just had the same problem and installed the fix. Afterwards I was able to uninstall again without errors. I had installed "JG4-dev-MVC-frontend".

Thanks

rowi68 commented 1 year ago

I have also tested this item :white_check_mark: successfully.

Before fix: 2023-08-16_18h05_54

After fix: 2023-08-16_18h07_14

ThomasFinnern commented 1 year ago

Tested successfuly

eumel1602 commented 1 year ago

test ok

MrMusic commented 1 year ago

@Elfangor93 can this PR merged? I think it would be important to be able to uninstall the component for further testing.

Elfangor93 commented 1 year ago

Works principially. But it intruduces redundant code. With this work around empty($modules->children()) gets checked double. PR #129 solves the same issue but does it with a bit nicer code.