search

JoomGalleryfriends / JG4-dev

Development repository for JoomGallery v4.x
GNU General Public License v3.0
10 stars 6 forks source link

Fix warning "Deprecated: Function strftime() is deprecated..." when editing images #136

Closed MrMusic closed 5 months ago

MrMusic commented 12 months ago

PHP 8.1: The use of the calendar field seems to generate this warning in Joomla in general. It should be sufficient to change in the xml file to translateformat="true". I don't know if there is a better solution? See also: https://github.com/JoomGalleryfriends/JG4-dev/issues/131#issue-1877971439

AlexanderSupp commented 12 months ago

I have installed this PR over the actual main and the warning was gone. That's great. Please merge into main.

Elfangor93 commented 12 months ago

I propose not to change things here, but to wait until this issue is fixed in the core. At the end of the day, it is just a warning and will not disturb users who doesn't have php error reporting to maximum.

The fix in the core is already detected: https://github.com/joomla/joomla-cms/pull/41224 and https://github.com/joomla/joomla-cms/issues/41444

You may help the people there to fix this issue...

MrMusic commented 11 months ago

but to wait until this issue is fixed in the core.

I am not sure if this problem will be fixed by Joomla itself. There are already several issues and pull requests on this topic at https://github.com/joomla/joomla-cms. But it seems that the problem isn't solved in the long term.

The fix in the core is already detected: https://github.com/joomla/joomla-cms/pull/41224 and https://github.com/joomla/joomla-cms/issues/41444

In Joomla 5 this pull request was merged: https://github.com/joomla/joomla-cms/pull/41453 Wasn't the problem also solved here with translateformat="true"? Someone should test whether the problem still exists in Joomla 5. Let's wait and see.