JoomGalleryfriends / JG4-dev

Development repository for JoomGallery v4.x
GNU General Public License v3.0
10 stars 6 forks source link

Show categories without images #169

Closed MrMusic closed 7 months ago

MrMusic commented 7 months ago

Currently, only (sub)categories that contain images are displayed in the category view. This PR ensures that empty categories are also displayed.

JochenEb commented 7 months ago

Funktioniert, habe es in der alpha1 händisch geändert. https://www.modellheliflieger.de/j4test

auch unter J5 https://www.modellheliflieger.de/j5test

rowi68 commented 7 months ago

I have also successfully tested this item... :white_check_mark:

AlexanderSupp commented 7 months ago

Yes, it works better than before. But if I change the "Filter by category" to "Root" the following page will be displayed: Screenshot 2023-12-17 131911

AlexanderSupp commented 7 months ago

Look at my structure. There are no images in the system. Screenshot 2023-12-17 132837 If I set the filter to "Reisen" the subcategory "2016 Brasilien" will be displayed. That's correct. Then, I select "2016 Brasilien" and no further categories will be displayed. I expect at this point my 4 subcategories.

Elfangor93 commented 7 months ago

Whtas the future of this PR? @MrMusic @AlexanderSupp Is there still anything to fix or can it be merged?

MrMusic commented 7 months ago

But if I change the "Filter by category" to "Root" the following page will be displayed:

Yes, i can confirm this, but i think it's a bug that is only now becoming visible. Try to fix:

Then, I select "2016 Brasilien" and no further categories will be displayed.

Can't confirm that. Maybe do you use outdated menu links?

AlexanderSupp commented 7 months ago

I started my test with "Category View Grid Layout" and not with "List of Categories". Now, I'm not sure that my problem can be assigned to this PR.

I started with this definition: Screenshot 2023-12-19 180700

The first page of "Category View Grid Layout" is: Screenshot 2023-12-19 180747

I click to "2016 Brasilien" and the next page is: Screenshot 2023-12-19 180844

Here I miss my 4 subcategories.

What I see now on the breadcrumbs is: There is a change to "Category View Masonry". Why that? I tried to start my test with "Category View Justified". The same result with "Category View Masonry" at the end. Now I will test these scenarios with images.

AlexanderSupp commented 7 months ago

I got it. I uploaded for all categories images. And, that is important, I add for each category a thumbnail for preview. And now everything works fine. But the standard view is always masonry. And now I can jump to all levels of categories and single image view with correct backlink. I can start with "List of Categories" and the chain works well. It seems that the parameters of masonry are always standard. And here my value for the title was None, so without a thumbnail for preview I didn't see the category.

My consequence for this PR. We must have a clear place to define the Category Layout. We must define a simple workflow to display all objects in the frontend.

AlexanderSupp commented 7 months ago

I checked this PR again. I deleted all images. Also, I deleted all my menu entries regarding the layout of Categories and images. And I make the titles visible. Now I can confirm the successful test.

This PR is ready to merge.

eumel1602 commented 7 months ago

auch ich habe den PR erfolgreich mit J4.4.1 getestet ( PHP 8.1 ) DANKE

MrMusic commented 7 months ago

But if I change the "Filter by category" to "Root" the following page will be displayed: Screenshot 2023-12-17 131911

I have added a fix so that this problem no longer occurs. For testing a new installation is needed.

AlexanderSupp commented 7 months ago

I uninstalled JG4 and installed this PR. Everything works as designed. I can switch around the category levels back and forth without any break. Thank you. PR ready to merge into main. Screenshot 2023-12-21 173437

Elfangor93 commented 7 months ago

Thank you very much ✅