JoomGalleryfriends / JG4-dev

Development repository for JoomGallery v4.x
GNU General Public License v3.0
10 stars 6 forks source link

[Configs] Change default value for image processing thumbnail #181

Closed reilldesign closed 1 month ago

reilldesign commented 6 months ago

All three available category views display landscape and portrait images well in combination. The masonry display only comes into its own when the image is reduced by width. It would be great to change the default setting to by width and 320px. Unfortunately I could not find the corresponding code for a pull request.

Global-Configuration-Image-Processing-thumbnail

MrMusic commented 6 months ago

It would be great to change the default setting to by width and 320px.

Which is the optimal size is certainly a matter of taste. For me personally, an ideal height of 200-250px would be better for the Justified layout. But it is certainly depends on the monitor size etc. DE: Welches die optimale Größe ist, ist sicherlich Geschmacksache. Für mich persönlich wäre beim Justified layout eine Ideal Height von 200-250px schöner. Ist aber sicherlich abhängig von der Monitorgröße usw.

Unfortunately I could not find the corresponding code for a pull request.

The default values can be found in script.php. From about line 713 you will find the default values for the respective image type. DE: Die Default-Werte sind in der script.php zu finden. Etwa ab Zeile 713 findest du für jeden Bild-Typ die Default-Werte (als JSON).

AlexanderSupp commented 6 months ago

A resizing by width makes no sense to me. A resizing by height is good for panorama, landscape, and portrait. And here I prefer 250. However, it's a matter of taste.

reilldesign commented 6 months ago

The following pixel widths result for the standard Cassiopeia template within the component area with deactivated boxed view.

Masonry Layout

3 columns = w 418px 4 columns = w 305px 5 columns = w 240px

Grid Layout

3 columns = w 320px 4 columns = w 305px 5 columns = w 236px

A width of 250px produces a lower image quality in the vast majority of displays.

Since the 3 column layout is very common i suggest a value between 320px and 380px.

AlexanderSupp commented 6 months ago

@reilldesign Thanks for this information. It's good to know something about the internals.

I tested some results of resizing the images. Keep in mind that I resize not by width. I resize by height!

grafik

As a consequence, I will change my resizing by Height to 380.

MrMusic commented 6 months ago

Whether you change by width or by height must actually be decided by each individual and depends on the used layout. With grid and justified layout, a change according to 'height' would make sense. With Masonry layout, a change according to 'width' would make sense. Some meaningful combinations (layout, number of columns, pixels...) could perhaps be made available to users as documentation?

DE: Ob man nach Breite oder nach Höhe ändert muss eigentlich jeder für sich entscheiden und ist vom verwendeten Layout abhängig. Bei Grid und justified Layout würde m. E. eine Änderung nach 'Höhe' Sinn ergeben. Beim Masonry layout würde m. E. eine Änderung nach 'Breite' Sinn ergeben. Einige sinnvolle Kombinationen (Layout, Spaltenzahl, Pixel...) könnte man den Anwendern evtl. in Form einer Doku zur Verfügung stellen?

Elfangor93 commented 1 month ago

Close issue since the topic was solved in a PR.