Closed reilldesign closed 7 months ago
The basis of the lightgallery works. At the end of the images, the first image will automatically start again. It would be nice if there was a stop at the end, otherwise confusion could arise with many images. The end of the images is influenced by the set maximum number of images per page. If these, for example, if the limit is set to 5, I only see the same 5 images over and over again. I expected to continue browsing until the end of all the images.
It would be pleasant if the lightgallery integration worked as shown in the demo. https://www.lightgalleryjs.com/ Click there on any thumbnail to open lightGallery
Wie ich teilweise im Issue #171 anführte, sind unabhängig von diesem PR lightgallery noch andere Unregelmäßigkeiten zu beobachten.
Sorry, here EN: As I stated in part in Issue #171, there are other irregularities observed independent of this PR lightgallery.
BTW: Are you sure that we can use these products without a licence? https://www.lightgalleryjs.com/license/
Works for me with a few pictures. But:
At the end of the images, the first image will automatically start again. It would be nice if there was a stop at the end, otherwise confusion could arise with many images.
This should be implemented.
I also have the black and white display. The reason for this is: In the grid and masonry layout the images get the class 'jg-image-thumb loaded'. In justified layout only the class 'jg-image-thumb'. This keeps the grayscale filter active.
There should be a separate config setting for the number of images displayed in the category view. The values specified via the selection list are generally not useful.
At the end of the images, the first image will automatically start again. It would be nice if there was a stop at the end, otherwise confusion could arise with many images.
DE:
Die schwarz-weiß-Darstellung habe ich auch. Die Ursache dafür ist: Im grid und masonry layout bekommen die Bilder die Klasse 'jg-image-thumb loaded'. Im justified layout nur die klasse 'jg-image-thumb'. Dadurch bleibt der grayscale-Filter aktiv.
Für die Anzahl der in der Kategorieansicht dargestellten Bilder sollte es eine eigene config-Einstellung geben. Die über die Auswahlliste vorgegebenen Werte sind im allg. nicht sinnvoll.
At the end of the images, the first image will automatically start again. It would be nice if there was a stop at the end, otherwise confusion could arise with many images.
DE: Der Fehler mit der schwarz-weiß Darstellung ist behoben. Die weiteren Punkte betreffen zusätzliche Features und könnnen später nachgereicht werden. Deshalb wäre ich dafür diesen PR zu mergen.
The error with the black and white display has been fixed. The other points concern additional features and can be added later. I would therefore be in favour of merging this PR.
I have tested this item ✅ successfully. Thank you very much.
This pull request offers lightgallery integration in category view and provides the infinite scroll function.