search

JoomGalleryfriends / JG4-dev

Development repository for JoomGallery v4.x
GNU General Public License v3.0
10 stars 7 forks source link

Improve configuration manager (by Elfangor) #21

Closed Elfangor93 closed 2 years ago

Elfangor93 commented 2 years ago

This PR is a further development of the PR #9.

The following changes are made (same as PR #9):

Additionally the following changes are made:

szepty-ziemi commented 2 years ago

Issue apply for both Windows and Linux.

Configuration Manager -> Configuration set -> General settings -> Upload

Show warning radio default option:

obraz

When clicking on it:

obraz

Then click again:

obraz

It doesn't return to default No state.

szepty-ziemi commented 2 years ago

ENV: https://prnt.sc/Qi06hS2mU4Qw - Windows ENV: https://prnt.sc/v14OtMkPbU0x - Linux

Issues:

showon list that was tested:

✓ Configuration Manager -> Configuration set -> User settings -> General settings

COM_JOOMGALLERY_CONFIG_UR_UU_USERSPACE="Allow userspace"

✓ Configuration Manager -> Configuration set -> User settings -> Upload

COM_JOOMGALLERY_CONFIG_UR_UU_UPLOAD_SINGLE="Enable Single Upload"

✓ Configuration Manager -> Configuration set -> User settings -> Download

COM_JOOMGALLERY_CONFIG_UR_UD_DOWNLOAD="Offer Downloads"

✓ Configuration Manager -> Configuration set -> User settings -> Ratings

COM_JOOMGALLERY_CATMAN_ALLOW_RATING="Allow Rating"

✓ Configuration Manager -> Configuration set -> General settings -> Image processing

COM_JOOMGALLERY_CONFIG_SHOWOPTIONS="Show options" <- this constant is not used (instead there is hardcoded "Show settings text" https://prnt.sc/UjRaf4G5uMLt )

✓ Configuration Manager -> Configuration set -> General settings -> Image processing (modal)

COM_JOOMGALLERY_CONFIG_GS_IP_RESIZING="Resizing" COM_JOOMGALLERY_CONFIG_DV_GS_ADD_WATERMARK="Add Watermark?"

✓ Configuration Manager -> Configuration set -> General settings -> Image processing (modal, watermark subform)

COM_JOOMGALLERY_CONFIG_DV_GS_WATERMARKSIZE="Watermark Size"

szepty-ziemi commented 2 years ago

ENV: https://prnt.sc/Qi06hS2mU4Qw - Windows ENV: https://prnt.sc/v14OtMkPbU0x - Linux

✓ global_only parameter in config.xml (Settings which can only be changed in the Global Configuration).

✓ add config parameter jg_filesystem (Selection of filesystem used for image storage).

✓ default Global configuration settings can't be deleted ✓ Bugfix: Save, Delete, Update imagetype table through config form (Image processing) ✓ subform layout used for Image processing settings (Table with modal containing settings) ✓ new subform layout named "repeatable-config" ✓ add default watermark file in configs.

Elfangor93 commented 2 years ago

@MrMusic If you are happy with this revision of your PR #9, please merge this PR and close yours...