search

JoomGalleryfriends / JG4-dev

Development repository for JoomGallery v4.x
GNU General Public License v3.0
10 stars 6 forks source link

Fix errors in system plugin #230

Closed Elfangor93 closed 1 month ago

Elfangor93 commented 1 month ago

This PR fix es issues reported in #226

There is an additional warning printed out in Joomla 5.x telling that Undefined array key 0 in C:\Users\Manuel\Documents\GitHub\JG4-dev\plugins\system\joomgallery\src\Extension\Joomgallery.php on line 219. This warning can not be solved without loosing functionality in Joomla 4.x. Possible PHP errors in future PHP versions are catched and handled not to loose functionality.

Reported Issue

Joomla\CMS\Event\Model\AfterCleanCacheEvent::onSetResult(): Argument https://github.com/JoomGalleryfriends/JG4-dev/pull/1 ($value) must be of type bool, array given, called in /joomla-root-verzeichnis/libraries/src/Event/AbstractEvent.php on line 227
MrMusic commented 1 month ago

0 Joomla\CMS\Event\Model\AfterCleanCacheEvent::onSetResult(): Argument https://github.com/JoomGalleryfriends/JG4-dev/pull/1 ($value) must be of type bool, array given, called in ...libraries/src/Event/AbstractEvent.php on line 227

Fixed in JoomGallery backend. But I still get the error in the Joomla backend, e.g. when saving the Joomla configuration, see https://github.com/JoomGalleryfriends/JG4-dev/issues/226#issue-2295693577

MrMusic commented 1 month ago

I have tested this PR ✅ successfully. Thank you very much.

reilldesign commented 1 month ago

I have tested this pull request ✅ successfully.