JoomGalleryfriends / JG4-dev

Development repository for JoomGallery v4.x
GNU General Public License v3.0
10 stars 7 forks source link

Reorganise toolbar buttons #46

Closed MrMusic closed 1 year ago

MrMusic commented 2 years ago

Possible fix for https://github.com/JoomGalleryfriends/JG4-dev/issues/11 The toolbar buttons now have the same order and identical names in all managers:

@Elfangor93 Do we need a 'state' (Publish) column for configuration(s) or can this column deleted?

Elfangor93 commented 2 years ago

@MrMusic I would like to have a publish column in the configuration manager.

MrMusic commented 2 years ago

@MrMusic I would like to have a publish column in the configuration manager.

Ok, i changed the toolbar in the configuration manager so that it is identical to the other managers. Because the functionality in the configuration is currently changed, the missing functions should be built in there: https://github.com/JoomGalleryfriends/JG4-dev/pull/47

szepty-ziemi commented 2 years ago

This looks very good now. One question: could we have different icons for button groups, that currently have three dots?

I think it will be good to distinguish them with different icons. Joomla 4 is using FontAwesome 5. Maybe we could use some of their fancy icons? :) Here are my suggestions:

Batch

https://fontawesome.com/icons/reply-all?f=classic&s=solid https://fontawesome.com/icons/recycle?f=classic&s=solid https://fontawesome.com/icons/shuffle?f=classic&s=solid

Status

https://fontawesome.com/icons/circle-dot?f=classic&s=regular https://fontawesome.com/icons/toggle-on?f=classic&s=solid https://fontawesome.com/icons/circle-check?f=classic&s=regular

Image Manipulation

https://fontawesome.com/icons/sliders?s=solid&f=classic https://fontawesome.com/v5/icons/images?s=regular&f=classic

MrMusic commented 2 years ago

@szepty-ziemi Thank you for your suggestions.

Batch I think the icons always suggest a certain function to the user. However, "Batch" can mean various functions. The icon should therefore be kept quite general or have a reference to the respective manager.

My suggestion would be to use the icon from the header for the respective manager. It is implemented like this for now. But maybe we should also leave the icon with the three dots to be compliant with Joomla?

Status For the state group, I have now taken the publish symbol with circle that you suggested: https://fontawesome.com/icons/circle-check?f=classic&s=regular

Image Manipulation For the image manipulation group in image manager I have now taken this one that you suggested: https://fontawesome.com/v5/icons/images?s=regular&f=classic

szepty-ziemi commented 2 years ago

@MrMusic I'm good witch your choice 😸

Elfangor93 commented 1 year ago

I tested this PR successfully. Thank you...