search

JoomGalleryfriends / JG4-dev

Development repository for JoomGallery v4.x
GNU General Public License v3.0
10 stars 6 forks source link

Improved messaging trait #60

Closed Elfangor93 closed 1 year ago

Elfangor93 commented 1 year ago

What is this trait for

The messaging trait adds a session based message handling to the component class (Joomgallery\Component\Joomgallery\Administrator\Extension\JoomgalleryComponent). It allows to collect warnings, debug information and error and output them as one message even over multiple reloads of the page. This is needed for operations with a long runtime needing multiple site refreshes to complete. In JG3 there was the debugoutput which acted in a similar way. This behaviour will be implemented with that in a more robust and expandable way.

How to test this PR

Create new images and categories. The behavior and the printed messages should not change from before this PR.

AlexanderSupp commented 1 year ago

Sounds good. Will watch that.

eumel1602 commented 1 year ago

I have created different images and categories. Produced one or the other error himself. Everything was properly displayed to me in the message. I can't see what exactly needs to be tested. The expected result: "The behavior and the printed messages should not change from before this PR." I don't understand. Maybe a more detailed explanation of what could be wrong or what to look out for...

MrMusic commented 1 year ago

I think you can't do more than check whether other or wrong messages appear. In my tests I could not see any problem. I think it should be merged.

eumel1602 commented 1 year ago

I think you can't do more than check whether other or wrong messages appear. In my tests I could not see any problem. I think it should be merged.

ok, then I couldn't find anything wrong