search

JoomGalleryfriends / JG4-dev

Development repository for JoomGallery v4.x
GNU General Public License v3.0
10 stars 6 forks source link

Fix warning missing variable $saveOrderingUrl #67

Closed MrMusic closed 1 year ago

MrMusic commented 1 year ago

Fix Warning: Undefined variable $saveOrderingUrl ... in images, categories and tags manager

Steps to reproduce the issue

Go to image manager, category manager or tags manager. Set sorting to 'ordering ascending'. Apply a filter so that no item is found. Maybe access is 'Special' or like something.

Expected result

A empty list or the message 'No Matching Results' like in Joomla should be shown.

Actual result

A warning is shown: Warning: Undefined variable $saveOrderingUrl ...

eumel1602 commented 1 year ago

I tried it in all three managers. Every time I got the info: No Matching Results (J4.2.6 / PHP 7.4 / WINDOWS )

bildschirmabgriff2

Elfangor93 commented 1 year ago

Code changes look good to me.

Elfangor93 commented 1 year ago

Fix Warning: Undefined variable $saveOrderingUrl

Warning only appears in PHP v8.x. With PHP 7.4 no warning was showed. Anyway the PR was testes successfully. Thank you very much.