JoomGalleryfriends / JG4-dev

Development repository for JoomGallery v4.x
GNU General Public License v3.0
10 stars 6 forks source link

Fix upload/filesystem issues #86

Closed Elfangor93 closed 1 year ago

Elfangor93 commented 1 year ago

This PR fixes some of the issues found in the area of

Namely it solves issues #44, #53, #56, #68, #85

This PR was build on top of PR #83. With applying this PR we are much closer to the final single upload process.

eumel1602 commented 1 year ago

can it be that this PR installation doesn't work? bildschirmabgriff

AlexanderSupp commented 1 year ago

I have exactly the same error-message.

Elfangor93 commented 1 year ago

The PR is still work in progress...

Elfangor93 commented 1 year ago

PR is now ready to test...

MrMusic commented 1 year ago

Error when saving the configuration: Save failed with the following error: Incorrect integer value: 'none' for column ..._joomgallery_configs.jg_msg_upload_type at row 1 It seems type 'tinyint(1)' is wrong.

MrMusic commented 1 year ago

One question about the path field in the categories database table: The default entry "uncategorised" does not contain a leading slash. Newly created categories have a leading slash "/". Which is correct?

reni68 commented 1 year ago

Tested issues #44 and #85 and both work:

44: Categories in file system correct and images - old and new - in category Cat-B.

     All thumbnails visible.

85: "no image" thumbnail is displayed.

Tested on Linux with XAMPP, Joomla 4.2.9 and PHP 8.0.15.

AlexanderSupp commented 1 year ago

68 Problem solved. Dot in Title of an image present and File Names OK.

reni68 commented 1 year ago

One question about the path field in the categories database table: The default entry "uncategorised" does not contain a leading slash. Newly created categories have a leading slash "/". Which is correct?

Global configuration can now be saved without error message.

Elfangor93 commented 1 year ago

The default entry "uncategorised" does not contain a leading slash. Newly created categories have a leading slash "/". Which is correct?

Without leading slash is correct. But a slash does not break functionality. But you pointed me towards some code which could make problems. I am working on it...

eumel1602 commented 1 year ago

I tested problems #44 #53 #85 #83. Everything works for me now. WIN / J.42.9 / PHP 8.0.x

What I noticed about the topic: #56 / If I use an image or a category or a tag with only one or more spaces as a title, it saves it, but I can never edit the image again. Saving a e.g. Image with only one space should show an error from my point of view! / when I save a second image with one or more spaces, the system automatically adds a "(2)" and so it's clickable...

bildschirmabgriff

Elfangor93 commented 1 year ago

@eumel1602 Can you please open an issue for your the titles issue? I will not fix this here in this PR...