search

JoomJunk / shoutbox

JJ Shoutbox module for Joomla! CMS. The most highly rated shoutbox on JED.
https://joomjunk.co.uk
6 stars 11 forks source link

Ensure there is no caching on the module #216

Closed wilsonge closed 8 years ago

wilsonge commented 8 years ago

This should fix https://joomjunk.co.uk/forum/jj-shoutbox/1280-disable-or-clear-cache-after-submit.html#2606 however I need to do some testing (this is totally untested at the moment) - it might need us to make an appropriate change in script.php as well

lsquall17 commented 8 years ago

Hi, i try it now and thats not work... But some modules use code like this: // check cache was endable ? if ($params->get('enable_cache')) { $cache = JFactory::getCache(); $cache->setCaching(true); $cache->setLifeTime($params->get('cache_time', 30) * 60); $rows = $cache->get(array($this, 'getArticles'), array($params)); } else { $rows = $this->getArticles($params); }

C-Lodder commented 8 years ago

@lsquall17 - Hey, once you tried adding the fix, did you go to the Shoutbox options in the Joomla backend, click save, set the caching the none, then click save again?

lsquall17 commented 8 years ago

@C-Lodder Yes, i try it again - add fix -> go backend -> open Shoutbox module -> set none caching -> save -> again check nocache -> save again -> testing, noting change.

If you want i can give you access to my VPS server.

wilsonge commented 8 years ago

Hi, If you change the name of this param from cache to owncache does that work? (see the change I've just made to the PR. (Usage here for my own reference in the future https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/module/helper.php#L510)