JoomShaper / helix-ultimate

53 stars 25 forks source link

Joomla 4 styling conflict with Helix Ultimate #243

Closed trainspotting closed 2 years ago

trainspotting commented 3 years ago

I reported a significant styling issue to a third party component developer - they researched and identified Helix Ultimate as causing a conflict.. They said...

For the toolbar buttons: The template implements some override to Joomla core toolbar buttons and it causes the issue. Somehow, the output of the buttons are incorrect, and it causes the issue

In the image the very colourful section just under the title should be a set of buttons - not all nested up like they all. In default Joomla 4 template they do show properly, but I get this with Ultimate.

error1

joomdonation commented 3 years ago

If anyone is having the issue, here is a quick modification I made for my customer. You can get this zip file, unzip it, upload to folder plugins\system\helixultimate\overrides\layouts\joomla to replace the old code and it should work OK

toolbar.zip

Shorty0811 commented 3 years ago

Thank you so much Tuan!!! :)

ximcix commented 2 years ago

Thanks for this fix

travelingflwr commented 2 years ago

I just tried this and no luck. Can you expand on what you changed to help me with troubleshooting this? My site currently has the issue with Helix Ultimate.

Shemeam commented 2 years ago

As always, way ahead of everyone else, thanks Tuan

joomdonation commented 2 years ago

It has been few months since the bug was reported. When do you think you can fix this bug @kawshar ? There are some other bugs like:

  1. The override for user form field broken (still uses behavior.modal which was removed in Joomla 4)
  2. The override for calendar form field (always show time for date picker for some reasons)
kawshar commented 2 years ago

It has been few months since the bug was reported. When do you think you can fix this bug @kawshar ? There are some other bugs like:

  1. The override for user form field broken (still uses behavior.modal which was removed in Joomla 4)
  2. The override for calendar form field (always show time for date picker for some reasons)

Informed the team. I hope the issue will be resolved soon.

Thanks

Shemeam commented 2 years ago

It wasn't fixed in the latest release causing additional work for everyone!!

joomdonation commented 2 years ago

@kawshar Could we have an update ? Our extensions support frontend management, so we are having this issue with every customers use Helix base templates. Any chance of having this fixed soon ?

chattigre commented 2 years ago

Will this issue be solved a day ? I have a problem with calendar fields as described previously by @joomdonation ... It's really exasperating to have to redo the same manipulation to delete broken overrides after each update which fix details like "Google Analytics update" but nothing about CORE bugs reported a long time ago and which break a lot of views !

It has been few months since the bug was reported. When do you think you can fix this bug @kawshar ? There are some other bugs like:

1. The override for user form field broken (still uses behavior.modal which was removed in Joomla 4)

2. The override for calendar form field (always show time for date picker for some reasons)

Hope the team will not only be "informed" but will be asked to solve bugs reports. Regards.

Shemeam commented 2 years ago

I have just upgraded Helix to Version 2.0.9 and it is still not fixed!!!!

mi-prakash commented 2 years ago

In the next update this issue will be resolved. Thank you all for your patience

joomdonation commented 2 years ago

Thanks. Looking forward to seeing these issues sorted

chattigre commented 2 years ago

In the next update this issue will be resolved. Thank you all for your patience

Thanks @prakash-a7x ! When will the next update be available please ? Soon ?

Regards.

Shemeam commented 2 years ago

@prakash-a7x you have marked this as fixed, but it is not fixed. Please explain when it will be fixed and when the next release of helixulitmiate with the fix will be available.

mi-prakash commented 2 years ago

We will update helix soon, I'm assuming within next week. So please be patience. @Shemeam, yes I've marked as fixed because its been fixed in dev branch...please wait for the update

joomdonation commented 2 years ago

@prakash-a7x Do you have a testing package which we can try and make sure the issues fixed ? If Yes, I would be happy to test and report back the result. Thanks

mi-prakash commented 2 years ago

@joomdonation yes, sure Please check with this package and let us know if you find any issue related to this thread or even other issue. Thank you helix_ultimate_pkg_2.0.9.zip

joomdonation commented 2 years ago

Thanks @prakash-a7x . Will test it and report the result back

mi-prakash commented 2 years ago

@joomdonation you are most welcome

joomdonation commented 2 years ago

@prakash-a7x I tested the package with my extensions and most of the issue is sorted. There is a remaining issue: Bootstrap Dropdown https://getbootstrap.com/docs/5.2/components/dropdowns/ is not working with your template for some reasons

If I replace this line of code https://github.com/JoomShaper/helix-ultimate/blob/master/plugins/system/helixultimate/src/Core/HelixUltimate.php#L354 (for Joomla 4) with HTMLHelper::_('bootstrap.framework'); to load bootstrap js from Joomla core, it is working well

Could you please check to see why Bootstrap Dropdown is not working with your template and get it fixed?

mi-prakash commented 2 years ago

@prakash-a7x I tested the package with my extensions and most of the issue is sorted. There is a remaining issue: Bootstrap Dropdown https://getbootstrap.com/docs/5.2/components/dropdowns/ is not working with your template for some reasons

If I replace this line of code https://github.com/JoomShaper/helix-ultimate/blob/master/plugins/system/helixultimate/src/Core/HelixUltimate.php#L354 (for Joomla 4) with HTMLHelper::_('bootstrap.framework'); to load bootstrap js from Joomla core, it is working well

Could you please check to see why Bootstrap Dropdown is not working with your template and get it fixed?

Thanks for your feedback. we will check on the issue

joomdonation commented 2 years ago

I wonder for Joomla 4 you should load bootstrap script shipped by Joomla instead of load your own bootstrap script ? As of right now, if third party extensions use HTMLHelper::_('bootstrap.framework'); to load bootstrap script, it will result in duplicate bootstrap script loaded (one from Joomla core and one from your own).

mi-prakash commented 2 years ago

@joomdonation We are aware of this issue. we are trying for a workaround of this problem.. hopefully in near updates we will resolve the problem. Thanks for your comment

joomdonation commented 2 years ago

Thanks @prakash-a7x . Hopefully it will also be fixed on your next update

joomleb commented 1 year ago

@prakash-a7x I tested the package with my extensions and most of the issue is sorted. There is a remaining issue: Bootstrap Dropdown https://getbootstrap.com/docs/5.2/components/dropdowns/ is not working with your template for some reasons

If I replace this line of code https://github.com/JoomShaper/helix-ultimate/blob/master/plugins/system/helixultimate/src/Core/HelixUltimate.php#L354 (for Joomla 4) with HTMLHelper::_('bootstrap.framework'); to load bootstrap js from Joomla core, it is working well

Could you please check to see why Bootstrap Dropdown is not working with your template and get it fixed?

@joomdonation As I reported here in detail https://github.com/JoomShaper/helix-ultimate/issues/258#issuecomment-1405329823 I still have back the same Bug.

Are you suggesting to change the line 354 (now 359 in Helix Ultimate 2.0.11) ? : $this->addjs('bootstrap.bundle.min.js'); with: HTMLHelper::('bootstrap.framework'); Am I right ?

Please, What about the line 363 ?!?: $this->add_js('popper.min.js, bootstrap.min.js');

...As of right now, if third party extensions use HTMLHelper::_('bootstrap.framework'); to load bootstrap script,... @joomdonation Please, Can you explain me a little bit more ? Maybe, Is this the reason because I'm having back the strange behavior I mentioned ?

I wonder for Joomla 4 you should load bootstrap script shipped by Joomla instead of load your own bootstrap script ? As of right now, if third party extensions use HTMLHelper::_('bootstrap.framework'); to load bootstrap script, it will result in duplicate bootstrap script loaded (one from Joomla core and one from your own).

@joomdonation I'm totally agree, by using Helix Ultimate on top of Joomla 4.x I don't see the need to force overriding of what is standard in Joomla 4.

@joomdonation We are aware of this issue. we are trying for a workaround of this problem.. hopefully in near updates we will resolve the problem. Thanks for your comment

@mi-prakash Maybe, in first of all, there should be a setting to exclude loading, as was done for "Advanced > Font Settings > Enable Font Awesome". Do you agree ? Can this: https://gist.github.com/dgrammatiko/efb3de4aa7cab4813a244f93f73cc0fd be useful ?