JoomShaper / helix-ultimate

52 stars 24 forks source link

helixultimate duplicates the functionalities provided by Joomla’s version of Bootstrap javascript #258

Open jgkiefer opened 2 years ago

jgkiefer commented 2 years ago

Steps to reproduce the issue

The duplicated bootstrap javascript creates conflicts with front-end drop-down menus (article edit, etc) not displaying.

Expected result

Only one call to bootstrap javascript instead of two. Front-end template drop-down menus work.

Actual result

Front end menus (article edit, print, etc) not clickable and will not open

System information (as much as possible)

Joomla 4.1.0 PhP 7.4.27 Helix 2.0.6 SP Page Builder Pro 3.8.3 Template shaper_helixultimate - Default

Additional comments

This has been verified on Joomshaper.com support form and I was asked to post here on Github

Here is a link to the support post

chattigre commented 2 years ago

Hello,

This bug is creating conflicts with main functionalities from Joomla Core (media fields, modals, accordions...) ! When will it be fixed please ?

Regards.

joomleb commented 1 year ago

@mi-prakash Why was this report closed? As far as I know it has not been fixed:

PHP 7.4.33 + Joomla 4.2.6 + Helix Ultimate 2.0.11 I added two Custom Modules to add two buttons (at the top right of my site) Clicking on them they are opening the standard Bootstrap 5 Dropdowns Let see the Code example here

They are working well on the entire site, except on these 2 pages:

Many Thanks to Andrew from OrdaSoft here I understood it could be a HelixUltimate Bootstrap 5 conflict.

Looking for a solution I found the @jgkiefer suggestion here (Thank You. PS now is line 359) that work on the exclusion of the /home/.../templates/shaper_helixultimate/js/bootstrap.bundle.min.js file. But applying it, the problem is reversed: the two buttons open the dropdowns only on the two pages:

Please, Can you suggest a solution here ? Do you have a trick / tip, a quick workaround ?

PS - By using Helix Ultimate on top of Joomla 4.x I don't see the need to force overriding of what is standard in Joomla 4. There should be a setting to exclude loading, as was done for "Advanced > Font Settings > Enable Font Awesome". Do you agree ? Can this: https://gist.github.com/dgrammatiko/efb3de4aa7cab4813a244f93f73cc0fd be useful ?

mi-prakash commented 1 year ago

In the next update hopefully this issue will be resolved thank you for your patience

joomleb commented 1 year ago

@mi-prakash Thank you, staying tuned. Please, let me know if you need full access to my test site (in case give me instruction on where to send details to you)

jgkiefer commented 1 year ago

This conflict also affects 3rd party extensions. I have had to comment it out each time I performed an extension upgrade. I first reported this a year ago, almost, now. I had given up hope that this bug would ever get fixed. Thank you for finally addressing it. I greatly look forward to the release of the fix upgrade.

From above: "PS - By using Helix Ultimate on top of Joomla 4.x I don't see the need to force overriding of what is standard in Joomla 4. There should be a setting to exclude loading, as was done for "Advanced > Font Settings > Enable Font Awesome". Do you agree?"

Yes, I agree completely.

mi-prakash commented 1 year ago

This conflict also affects 3rd party extensions. I have had to comment it out each time I performed an extension upgrade. I first reported this a year ago, almost, now. I had given up hope that this bug would ever get fixed. Thank you for finally addressing it. I greatly look forward to the release of the fix upgrade.

From above: "PS - By using Helix Ultimate on top of Joomla 4.x I don't see the need to force overriding of what is standard in Joomla 4. There should be a setting to exclude loading, as was done for "Advanced > Font Settings > Enable Font Awesome". Do you agree?"

Yes, I agree completely.

About the settings I do have to talk with the team and give a confirmation. right now we tested with bootstrap conflicts, like bootstrap dropdown, popover, tooltip etc

joomleb commented 1 year ago

Hi guys, @mi-prakash, Helix Ultimate 2.0.12 has been released. I Tested it and the bootstrap dropdown conflict Bug seems has been fixed with success... Thank You.

Anyway, as far as I understand, this topic remain open waiting news about the setting to exclude Bootstrap loading in Joomla 4

Savama51 commented 1 year ago

Hi all,

I think that removing the bootstrap could be a long long work, because Helix Ultimate has been initialy developed for Joomla 3 (which doesn't include modern boostrap).

Then, HU has been adapted to work with Joomla 4, mixing boostraps, instead of using only J4 included bootstrap...

For now, I believe that the dev team will patch conflicts instead of adding option to exclude boostrap from their codes, because of too much work for a free working extension...

Am I right, JoomShaper dev's team ?

mi-prakash commented 1 year ago

@Savama51 yes, we will work with the bootstrap issue when J3 is finally dead.

mi-prakash commented 1 year ago

@joomleb We suggest you to close this issue and for the settings feature you are requesting please create a new issue describing that. In that case we can manage the git hub issues more effectively. Thank you

joomleb commented 1 year ago

@mi-prakash done #313 Thank You

For me, if @jgkiefer confirm the fixing of this issue with Helix Ultimate 2.0.12, you can close this ticket

joomleb commented 5 months ago

@mi-prakash as far as I know, this should be confirmed as solved with Helix Ultimate 2.1.1, Can you ? ...and the ticket can be closed, thank you