JoomShaper / helix-ultimate

53 stars 24 forks source link

logo.php (template features) : wrong height attribut value #348

Open Savama51 opened 1 year ago

Savama51 commented 1 year ago

Steps to reproduce the issue

For px unit : Add a png image in the param Basis > Logo > Logo. Set the Logo Height to 60, px (unit)

Or for other units : Set the Logo Height to 16, em (unit)

Expected result

In html code source for px unit :

<img class='logo-image '
srcset='https:/mywebsite.com/images/my_logo.png 1x'
src='https:/mywebsite.com/images/my_logo.png'
height="60"
alt='My Website !'

Or for other units :

<img class='logo-image '
srcset='https:/mywebsite.com/images/my_logo.png 1x'
src='https:/mywebsite.com/images/my_logo.png'
alt='My Website !'

Actual result

In html code source for px unit :

<img class='logo-image '
srcset='https:/mywebsite.com/images/my_logo.png 1x'
src='https:/mywebsite.com/images/my_logo.png'
height='60px'
alt='My Website !'

Or for other units :

<img class='logo-image '
srcset='https:/mywebsite.com/images/my_logo.png 1x'
src='https:/mywebsite.com/images/my_logo.png'
height='16em'
alt='My Website !'

System information (as much as possible)

Joomla! 4.3.4 Helis Ultimate 2.0.14

Additional comments

In the HTML doc, height value specifies the height of an image *in pixels". So, the value of logo height should be displayed without "px", and only if px is the unit selected !

The attribut height sould be removed if other unit than px is selected ?

The height attribute is not présent for the mobile logo... should it be ?

mi-prakash commented 11 months ago

@Savama51 this issue has been fixed in the recent updates.. can u confirm ?

Savama51 commented 11 months ago

@mi-prakash I've tested with latest 2.0.16, same issue.

joomleb commented 4 months ago

Hi guys, @Savama51 Please, Can you confirm the bug with the last Joomla 4.4.4 + Helix Ultimate 2.1.1 ?

Savama51 commented 4 months ago

Hi guys, @Savama51 Please, Can you confirm the bug with the last Joomla 4.4.4 + Helix Ultimate 2.1.1 ?

Hello, Unfortunately, problem remains with latest 2.1.1 version...