search

JoomShaper / helix-ultimate

53 stars 25 forks source link

Undefined variable in override file intro_image.php #371

Open mojeweb opened 1 year ago

mojeweb commented 1 year ago

Steps to reproduce the issue

In HU 2.0.17 open article.

Expected result

Article opens with no errors.

Actual result

I get PHP notice: Undefined variable: JoomlaVersion in /plugins/system/helixultimate/overrides/layouts/joomla/content/intro_image.php on line 90

And with local server I get Forbidden You don't have permission to access /blog/article-alias on this server.

If I add this code to file intro_image.php, all is ok: // Define the variable $JoomlaVersion $version = new Version(); $JoomlaVersion = $version->getShortVersion();

System information (as much as possible)

J 4.4.0 HU 2.0.17 PHP 7.4.2

Additional comments

No problem with casiopea.

mojeweb commented 1 year ago

I see that in your original code, $JoomlaVersion is defined within a conditional block (line 57), specifically inside an if statement. If the if condition is not met, the variable may not be defined, which can lead to the "Undefined variable: JoomlaVersion" notice if you try to use it later.

joomleb commented 6 months ago

@mojeweb Please, Can you replicate / confirm the issue with the last Joomla 4.4.5 + Helix Ultimate 2.1.1 ? (Which version of PHP are you running?)

OR, Can we consider this as "solved",?