JoomShaper / helix-ultimate

53 stars 25 forks source link

[2.0.18 bug] Twitter social icon #373

Open joomleb opened 1 year ago

joomleb commented 1 year ago

Hi guys, PHP 7.4.33 / 8.1.22 + Joomla 4.4.0 + HU 2.0.17 or 2.0.16 where I can read in the changelog: "Updated the Twitter X logo on social icons". It was running on 2.0.15.

The Twitter social icon is shown in a "fixed way" and custom CSS on the social icons, like: ul.social-icons > li { font-size: 36px; margin: 0 0.5rem; } Is not applied anymore to the Twitter X one. I tried also changing ..templates/shaper_helixultimate/features/social.php file:

That should be the obvious way because in Helix Ultimate we can always set:

While you added the extra code (around line 126) where

Please, Can you confirm ? Is it the right way ?!?

imsherlocked commented 1 year ago

hello @joomleb can you assign this issue to me, I am starting my open source contribution journey and it could be my first step in this journey.

joomleb commented 1 year ago

@imsherlocked nice to meet you! Unfortunately I'm not part of the Helix Ultimate team, sorry. @mi-prakash Please, Can you help @imsherlocked ?

I remain available...

mi-prakash commented 1 year ago

@joomleb For now we are using svg. in future we will use the font awesome icons when the font awesome 6 gets more popular. To adjust anything u can use custom css. thank you

joomleb commented 1 year ago

Hi @mi-prakash "...when the font awesome 6 gets more popula..." ?!? = FA6 is the default on Joomla 5 and with HU 2.0.16 changelog you added "Joomla 5 compatibility" HU 2.0.17 changelog you added "Font Awesome updated to 6.4.2"...

It should means that if I''m running on Joomla 4 (FA5) I set: HU Advanced > Font settings > Enable Font Awesome: enabled

If I'm running Joomla 5 (FA6) I set: HU Advanced > Font settings > Enable Font Awesome: disabled

That's all. OR Please, What is the "HU Advanced > Font settings > Enable Font Awesome" setting sense ?!?