search

Joomla-Bible-Study / Proclaim

Joomla Proclaim Component - Christian Web Ministries
https://www.christianwebministries.org/
GNU General Public License v3.0
10 stars 9 forks source link

Module: use template system? #288

Closed st-anton closed 10 years ago

st-anton commented 11 years ago

currently, in the module are a lot of settings, but I have no idea, what they are good for. Settings for template of studies, teachers and so on. Also full stettings of the table to show a studies list. As far as I see, the module is used for display if the studies list only. No teachers list and so on. Is this right or did I miss something? So what are the settings good for? Second, there is a setting which template is used for studies list. Here you can select one of the templates set up and maintained in the component. (As far as I see, this is not used). Isn't it an better idea, to drop all the settings of the stadies list here and use the template system of the component? Or is the idea of the module to show specific studies only (filter) and the filter and template cannot be taken out of two different setting parameters?

tomfuller2 commented 11 years ago

The module is designed as a way to filter a studies list. It can be copied and changed according to whatever the admin wants to do. It should connect to a template when the user clicks on a study.

using just template settings defeats the purpose of having multiple modules of the same type.

If there are settings that are actually not used, I'd like to know!

On Fri, Aug 9, 2013 at 1:05 PM, st-anton notifications@github.com wrote:

currently, in the module are a lot of settings, but I have no idea, what they are good for. Settings for template of studies, teachers and so on. Also full stettings of the table to show a studies list. As far as I see, the module is used for display if the studies list only. No teachers list and so on. Is this right or did I miss something? So what are the settings good for? Second, there is a setting which template is used for studies list. Here you can select one of the templates set up and maintained in the component. (As far as I see, this is not used). Isn't it an better idea, to drop all the settings of the stadies list here and use the template system of the component? Or is the idea of the module to show specific studies only (filter) and the filter and template cannot be taken out of two different setting parameters?

— Reply to this email directly or view it on GitHubhttps://github.com/Joomla-Bible-Study/Joomla-Bible-Study/issues/288 .

st-anton commented 11 years ago

Yes, that's the way I thought it should be used. During my review of the phrases I saw a) some unused settings and b) got an idea that may be discussed. Let me explain my thoughts more in detail: The first setting says: Template for this page. So I thought, one of the components template is used. But I cannot see this. Instead, it uses its own setting. But most of the settings are equal in the module and the component template manager: Filter, settings of the stuiedies list, tooltips and so on. And the template manager even offers more: save the template as a copy, import and export files and so on. My idea: Let the user generate a common template and an additional template (with 'save as', export/import), that sets the filter suitable for the individual module instance. This leads to a more common understanding of the templates, one input of the template only and an easier setup of an equal display style of the table. What do you think about this?

tomfuller2 commented 10 years ago

The module now follows the same pattern as the other views - using the Fluid Listing found in /lib/listing.php