search

Joomla-Bible-Study / Proclaim

Joomla Proclaim Component - Christian Web Ministries
https://www.christianwebministries.org/
GNU General Public License v3.0
11 stars 9 forks source link

BootStrap spanning problem. #399

Closed bcordis closed 9 years ago

bcordis commented 9 years ago

Right now the way the spanning is generated it dos not account for the a full span12.

like fore span1 do not = span12

We need to change to a calculated spanning system.

tomfuller2 commented 9 years ago

Okay. I'll take a look tomorrow.

On Sunday, December 28, 2014, Brent Cordis notifications@github.com wrote:

Right now the way the spanning is generated it dos not account for the a full span12.

like fore span1 do not = span12

We need to change to a calculated spanning system.

— Reply to this email directly or view it on GitHub https://github.com/Joomla-Bible-Study/Joomla-Bible-Study/issues/399.

tomfuller2 commented 9 years ago

So can you be more specific? I'm not seeing where we don't account for the spans as is. If I set a row to span12 it comes out at span12 in the resulting code. Where are you seeing this?

bcordis commented 9 years ago

Look at it this way we have for columns. That means you need each one to equal span3 for each of them.

Right now we have know way to translate the old way to the new bootstrap layout.

We almost need to make it calculate the how many columns are used and have a maximum number columns. This way we can us bootstrap right.

If we need to do a call let me know so we can get it worked out right.

On Monday, December 29, 2014, Tom Fuller notifications@github.com wrote:

So can you be more specific? I'm not seeing where we don't account for the spans as is. If I set a row to span12 it comes out at span12 in the resulting code. Where are you seeing this?

— Reply to this email directly or view it on GitHub https://github.com/Joomla-Bible-Study/Joomla-Bible-Study/issues/399#issuecomment-68319848 .

Sent from Gmail Mobile

tomfuller2 commented 9 years ago

There isn't a good way to migrate from the way folks have their current listings set - it's apples and oranges - from setting each individual cell of a 4x4 table, to having a 6x12 with whatever combination they want. It's up to the admin to determine that they are using all 12 spans of each row.

But in the lib/listing.php starting on row 615 you can see where we get the spans from - which is translated into the fluid rows. I suppose an admin could choose too many items with too long of a total span for a row - but that's something up to them. I don't think we should be trying to calculate and remove stuff from the template record if they overshoot a row.

Perhaps we can talk later this afternoon?

On Mon, Dec 29, 2014 at 7:21 PM, Brent Cordis notifications@github.com wrote:

Look at it this way we have for columns. That means you need each one to equal span3 for each of them.

Right now we have know way to translate the old way to the new bootstrap layout.

We almost need to make it calculate the how many columns are used and have a maximum number columns. This way we can us bootstrap right.

If we need to do a call let me know so we can get it worked out right.

On Monday, December 29, 2014, Tom Fuller notifications@github.com wrote:

So can you be more specific? I'm not seeing where we don't account for the spans as is. If I set a row to span12 it comes out at span12 in the resulting code. Where are you seeing this?

— Reply to this email directly or view it on GitHub < https://github.com/Joomla-Bible-Study/Joomla-Bible-Study/issues/399#issuecomment-68319848>

.

Sent from Gmail Mobile

— Reply to this email directly or view it on GitHub https://github.com/Joomla-Bible-Study/Joomla-Bible-Study/issues/399#issuecomment-68326793 .

bcordis commented 9 years ago

Ok so we need to make up a statement to have after installation to have them go and reconfigure there span's we can now use the post installation system in Joomla.

bcordis commented 9 years ago

We need to fix the example code to use the spans correctly. Right now we use only span1 and need to us span4 and so on to make it look right.

tomfuller2 commented 9 years ago

I guess I figured they'd set that when they first go in. But no where are we explaining the new system. I was thinking that our help system on the website would provide that. What do you think?

bcordis commented 9 years ago

Yes are website should go into detail but we do need to make a statement to that fact that the template system has changed.

tomfuller2 commented 9 years ago

Do you know how to implement that? Here is some suggested language: Version 9.x of Joomla Bible Study uses the native Bootstrap system to create responsive views. In order to implement this on your website, go to Templates and open the default record. Set spans in the items to display according to how wide you want them. Span1 is 1/12 of the width of the screen; Span12 is the entire width.

Also - when I use Phing to build the package - the component comes out at 10mb. I'm sure that's not right.

st-anton commented 9 years ago

As written in #438 the postinstall messages cannot be used currently to put a message. Either the postinstall comonent needs to be hacked or the language file needs to be placed in the CORE language folder.

bcordis commented 9 years ago

@st-anton did the language hack in the template.php file not work?

st-anton commented 9 years ago

No :-)) I got it! There's a simple reason, why it does not work: The installer scipt does not install the postinstall folder - and therefor no template.php is present. Please add the folder in \com_biblestudy\biblestudy.xml

bcordis commented 9 years ago

@st-anton see fix for postinstall in the xml file 094c6f2971ec6b19d13cb87a48606d7f37da6175

bcordis commented 9 years ago

closing as fixed we have a solution.