search

Joomla-Bible-Study / Proclaim

Joomla Proclaim Component - Christian Web Ministries
https://www.christianwebministries.org/
GNU General Public License v3.0
10 stars 9 forks source link

Using download popup message results in popup icon dissapearing #883

Closed tomfuller2 closed 2 years ago

tomfuller2 commented 2 years ago

to reproduce: choose Show popup message before download in the template.

On studylist the popup icon disappears.

bcordis commented 2 years ago

@tomfuller2 try testing with the new fix.

tomfuller2 commented 2 years ago

It opens in a new tab, not a modal. Also, there is a MySQL error when you try to click on the download.

bcordis commented 2 years ago

@tomfuller2 This may be something we need to re-design as it was a pop up and not a model. Can you send me SQL error?

tomfuller2 commented 2 years ago

Here is the url (I know it won't work on your install) http://localhost:8888/j4/index.php?option=com_proclaim&task=CWMSermons.download&mid=4022&Itemid=138

And part of the call stack Call stack

| Function | Location

1 | () | JROOT/libraries/vendor/joomla/database/src/Mysqli/MysqliStatement.php:141 2 | Joomla\Database\Mysqli\MysqliStatement->__construct() | JROOT/libraries/vendor/joomla/database/src/Mysqli/MysqliDriver.php:1048 3 | Joomla\Database\Mysqli\MysqliDriver->prepareStatement() | JROOT/libraries/vendor/joomla/database/src/DatabaseDriver.php:1900 4 | Joomla\Database\DatabaseDriver->setQuery() | /Users/Tom/PhpstormProjects/Proclaim/site/src/Helper/CWMdownload.php:163

tomfuller2 commented 2 years ago

This was fixed with: https://github.com/Joomla-Bible-Study/Proclaim/commit/30c03371e39dba41ce84e2ccba38d6edc2c897f8