Joomla-Bible-Study / Proclaim

Joomla Proclaim Component - Christian Web Ministries
https://www.christianwebministries.org/
GNU General Public License v3.0
10 stars 9 forks source link

Unable to save Teacher image #897

Closed tomfuller2 closed 1 year ago

tomfuller2 commented 1 year ago

Upload or select a Teacher Image. Save.

An error has occurred. 0 The image file does not exist.

tomfuller2 commented 1 year ago

The error message comes from site - libraries - src - image - image.php on line 180. Apparently the path isn't valid. I'm wondering if it has to do with working on a localhost?

bcordis commented 1 year ago

This is a problem we need to discuss. The way we resize images on save is a problem.

On Mon, Aug 22, 2022 at 3:27 PM Tom Fuller @.***> wrote:

Upload or select a Teacher Image. Save.

An error has occurred. 0 The image file does not exist.

— Reply to this email directly, view it on GitHub https://github.com/Joomla-Bible-Study/Proclaim/issues/897, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHSXU7EEI2AFLOW5EY72TTV2PPB5ANCNFSM57I7VQUQ . You are receiving this because you were assigned.Message ID: @.***>

-- Sent from Gmail Mobile

tomfuller2 commented 1 year ago

Fixed by adding directory="biblestudy" to the media fields. https://github.com/Joomla-Bible-Study/Proclaim/commit/eca7087b5ba90abc4203be3bcd233ac9310418b9

tomfuller2 commented 1 year ago

This is not fixed for some views

tomfuller2 commented 1 year ago

Something is happening after selection of an image.

Appendded to the image path is a part of what appears to be js.

images/biblestudy/Tom11-22-21-1-100.jpg#joomlaImage://local-images/biblestudy/Tom11-22-21-1-100.jpg?width=100&height=125

not sure why this happens!

In the message.xml I remove the string using strpos and substr. This is not an answer.

tomfuller2 commented 1 year ago

Libraries src form field MediaField.php seems to be the source.

on line 265

tomfuller2 commented 1 year ago

So oddly, this might either be something involved with my site on localhost - or is expected behavior. I created a banner and the image also has the same tag on it:

images/banners/banner.jpg#joomlaImage://local-images/banners/banner.jpg?width=1140&height=600.

What they are doing is making the image part of their params. The db entry under the params field is:

{"imageurl":"images\/banners\/banner.jpg#joomlaImage:\/\/local-images\/banners\/banner.jpg?width=1140&height=600","width":"","height":"","alt":""}

This is apparently now an issue with Joomla 4: https://issues.joomla.org/tracker/joomla-cms/35871

tomfuller2 commented 1 year ago

This is fixed