Joomla-Bible-Study / Proclaim

Joomla Proclaim Component - Christian Web Ministries
https://www.christianwebministries.org/
GNU General Public License v3.0
10 stars 9 forks source link

Pagination on some admin lists does not work #906

Closed tomfuller2 closed 11 months ago

tomfuller2 commented 1 year ago

Clicking one of the links on the admin side does not move forward in the list

tomfuller2 commented 1 year ago

THis is on the mediafiles view

tomfuller2 commented 1 year ago

What's happening is $limitstart is not being passed to the pagination method.

tomfuller2 commented 1 year ago

This is happening on all admin views.

tomfuller2 commented 1 year ago

Fixed - duplicate pagination found. Removed one. https://github.com/Joomla-Bible-Study/Proclaim/commit/c4ed3db242c3d08fdc3115b0acaa997e75ecd3e0

tomfuller2 commented 1 year ago

Fixed this in messages list but it still doesn't work in media files.

tomfuller2 commented 1 year ago

Teachers list also does not work with pagination.

tomfuller2 commented 1 year ago

Also series.

Topics works. Servers works. Comments work. Templatecodes work.

tomfuller2 commented 1 year ago

So just to update:

Pagination does NOT work on admin: MediaFiles, Teachers, Series.

It also does NOT work on site: series

The links at the bottom of the page are correct - the same for the working Studies list.

a aria-label="Go to page 3" href="#" onclick="document.adminForm.limitstart.value=40; Joomla.submitform();return false;" class="page-link"> 3

But $limitstart is being removed prior to it getting to the Pagination.php file under Libraries/src/Pagination

tomfuller2 commented 1 year ago

I'm wondering if there is a way to test the javascript here. Seems the info for the limitstart is correct in a < a href but does not get passed on to the ListModel or Pagination.

bcordis commented 1 year ago

Added the core JS to all List views. Working through the code to update the views with all the new J4 code.

bcordis commented 1 year ago

@tomfuller2 Please retest all views and verify if all is fixed.

bcordis commented 1 year ago

@tomfuller2

bcordis commented 11 months ago

This has been fixed in dev