search

Joomla-Bible-Study / Proclaim

Joomla Proclaim Component - Christian Web Ministries
https://www.christianwebministries.org/
GNU General Public License v3.0
10 stars 9 forks source link

New window player results in 404 #908

Closed tomfuller2 closed 9 months ago

tomfuller2 commented 1 year ago

Clicking on a player as new window - url such as:

Result is 404

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">

View not found [name, type, prefix]: page, html, site

 Home Page

Call stack |   |   -- | -- | -- # | Function | Location 1 | () | JROOT/libraries/src/MVC/Controller/BaseController.php:816 2 | Joomla\CMS\MVC\Controller\BaseController->getView() | JROOT/libraries/src/MVC/Controller/BaseController.php:602 3 | Joomla\CMS\MVC\Controller\BaseController->display() | JROOT/components/com_proclaim/src/Controller/DisplayController.php:127 4 | CWM\Component\Proclaim\Site\Controller\DisplayController->display() | JROOT/libraries/src/MVC/Controller/BaseController.php:672 5 | Joomla\CMS\MVC\Controller\BaseController->execute() | JROOT/libraries/src/Dispatcher/ComponentDispatcher.php:143 6 | Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch() | JROOT/components/com_proclaim/src/Dispatcher/Dispatcher.php:47 7 | CWM\Component\Proclaim\Site\Dispatcher\Dispatcher->dispatch() | JROOT/libraries/src/Component/ComponentHelper.php:355 8 | Joomla\CMS\Component\ComponentHelper::renderComponent() | JROOT/libraries/src/Application/SiteApplication.php:200 9 | Joomla\CMS\Application\SiteApplication->dispatch() | JROOT/libraries/src/Application/SiteApplication.php:241 10 | Joomla\CMS\Application\SiteApplication->doExecute() | JROOT/libraries/src/Application/CMSApplication.php:294 11 | Joomla\CMS\Application\CMSApplication->execute() | JROOT/includes/app.php:61 12 | require_once() | JROOT/index.php:32

404 View not found [name, type, prefix]: page, html, site  Home Page Call stack

Function Location

1 () JROOT/libraries/src/MVC/Controller/BaseController.php:816 2 Joomla\CMS\MVC\Controller\BaseController->getView() JROOT/libraries/src/MVC/Controller/BaseController.php:602 3 Joomla\CMS\MVC\Controller\BaseController->display() JROOT/components/com_proclaim/src/Controller/DisplayController.php:127 4 CWM\Component\Proclaim\Site\Controller\DisplayController->display() JROOT/libraries/src/MVC/Controller/BaseController.php:672 5 Joomla\CMS\MVC\Controller\BaseController->execute() JROOT/libraries/src/Dispatcher/ComponentDispatcher.php:143 6 Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch() JROOT/components/com_proclaim/src/Dispatcher/Dispatcher.php:47 7 CWM\Component\Proclaim\Site\Dispatcher\Dispatcher->dispatch() JROOT/libraries/src/Component/ComponentHelper.php:355 8 Joomla\CMS\Component\ComponentHelper::renderComponent() JROOT/libraries/src/Application/SiteApplication.php:200 9 Joomla\CMS\Application\SiteApplication->dispatch() JROOT/libraries/src/Application/SiteApplication.php:241 10 Joomla\CMS\Application\SiteApplication->doExecute() JROOT/libraries/src/Application/CMSApplication.php:294 11 Joomla\CMS\Application\CMSApplication->execute() JROOT/includes/app.php:61 12 require_once() JROOT/index.php:32

tomfuller2 commented 1 year ago

Fixed temporarily by substituting popup code for new window in player.

https://github.com/Joomla-Bible-Study/Proclaim/commit/e8977d598dab01d2e41fec267b4baa2371185c22

bcordis commented 1 year ago

@tomfuller2 Can you look into this again as now I'm seeing the popup working again?

bcordis commented 1 year ago

@tomfuller2 Ping

tomfuller2 commented 1 year ago

I can’t really test until I get the media back on the site side

On Fri, Feb 10, 2023 at 1:02 PM Brent Cordis @.***> wrote:

@tomfuller2 https://github.com/tomfuller2 Ping

— Reply to this email directly, view it on GitHub https://github.com/Joomla-Bible-Study/Proclaim/issues/908#issuecomment-1426341348, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJYYXJYLJAXB3B3ROQJCQLWW2UGZANCNFSM6AAAAAARDWX5P4 . You are receiving this because you were mentioned.Message ID: @.***>

-- Tom Fuller, APR

Founder and Principal

Imagine Public Relations

www.ImaginePublicRelations.com 971-832-9494 | 503-550-4067 @.*** www.ImagineVisualProductions.com https://www.imaginevisualproductions.com/ [image: facebook] https://www.facebook.com/imaginepublicrelations [image: twitter] https://twitter.com/thomasefuller [image: linkedin] https://www.linkedin.com/in/tomfuller/

bcordis commented 11 months ago

@tomfuller2 after update can you now verify this is fixed so we can close it out.

tomfuller2 commented 11 months ago

I'm getting this error: CWM\Component\Proclaim\Site\Helper\CWMImages::getSeriesThumbnail(): Argument #1 ($image) must be of type string, null given, called in /Users/tomfuller/PhpstormProjects/Proclaim/site/src/View/CWMPopUp/HtmlView.php on line 208

bcordis commented 9 months ago

@tomfuller2 Is this fixed now? I'm not able to reproduce it after changes to the photo rendering.

tomfuller2 commented 9 months ago

I believe this is fixed.