JoosepAlviste / nvim-ts-context-commentstring

Neovim treesitter plugin for setting the commentstring based on the cursor location in a file.
MIT License
1.13k stars 34 forks source link

fix: rescript jsx comments #77

Closed dkirchhof closed 11 months ago

JoosepAlviste commented 11 months ago

Hey! Could you show some cases where the current configuration fails? It looks like JSX commenting wouldn't work in rescript after this change. I haven't used rescript myself, but it should support JSX, right?

dkirchhof commented 11 months ago

In ReScript JSX comments are the same like in the rest of the language. Here is a playground link:

https://rescript-lang.org/try?version=v10.1.2&code=AIJwpghgxgLgdFA9gWwA6IHZgzAUAGzBgAJkIBrMYgXmIAoBKGgPl2OIB4ATASwDdW7dgHphnABYBGZsQDeAJUiw4AZxggeGAOZ0AROLD58iYgHdEIfF10MAvp2FTBQ4QCoJ0uYujw1G7XoGRibmltZ2Dk7ErsJsQrJuHjIKSr7qmjr6hsZmFlY29hyOnjG2cUW8ArhAA

JoosepAlviste commented 11 months ago

Oh I see, thanks for the example! And thanks for the contribution, also 😄