Closed felixnorden closed 10 months ago
Sounds like a good plan, I’ll look to get those pieces covered tomorrow with a new commit to make sure we have a non-breaking change and update docs!
@JoosepAlviste , I added in the changes but wasn't sure about how to mark the config
field for deprecation properly. Apart from this, I think that the logic should be in order for merging languages
and config
based on the internal logic and allowing for overrides/extensions.
Let me know if you want me to put the merge from keep
to force
in the table merge, however, in case this needs to be done for end-user overrides/extensions to have priority over the supported languages out of the box!
Roger that, will have a look on your comments and make sure we cover that as well! 👍 thanks for taking the time to go through it!
Looks great now, thanks for the contribution! And thanks for taking care of the config key renaming 😄
Wanted to add in some additional language comment types in here as I was lacking some of them myself in my flow using LazyVim! Please let me know if there's anything needed further to get this merged in!
This commit will:
sh
fileszsh
filessolidity
filesc
filesconfig
table inside theconfig
tolanguages
as written in the TODO above