search

JoosepAlviste / nvim-ts-context-commentstring

Neovim treesitter plugin for setting the commentstring based on the cursor location in a file.
MIT License
1.13k stars 34 forks source link

Remove nvim-treesitter, use nvim 0.9+ core utilities #80

Closed Slotos closed 9 months ago

Slotos commented 10 months ago

With 0.9 being the minimal version for this plugin, nvim-treesitter is quite literally a fifth wheel for its functionality. It installs and updates parsers, but everything this plugin needs to operate afterwards is available in the core vim.treesitter utilities set.

I also borrowed a test setup from aerial.nvim, to create a minimal setup launcher bash script that truly isolates minimal config from main user configuration.

JoosepAlviste commented 9 months ago

This looks great now! Just the Stylua check to fix and the deprecation message wording, and then we can merge it 🎉

Thanks for taking care of the fixes and improvements!

JoosepAlviste commented 9 months ago

Thanks for the great work on this! It feels great to get rid of some useless code 🎉

I also created an issue with the breaking changes and mentioned this there: https://github.com/JoosepAlviste/nvim-ts-context-commentstring/issues/82#issuecomment-1817659634 and updated the integrations wiki: https://github.com/JoosepAlviste/nvim-ts-context-commentstring/wiki/Integrations.

Hopefully this won't be too big of a pain for users 🤞