search

JoostKiens / dc-meta-tags

WordPress plugin to add Dublin Core meta data (Element Set v1.1) to wp_head()
GNU General Public License v3.0
7 stars 3 forks source link

requires_wordpress_version() not working [bug] #8

Closed Tintazul closed 10 years ago

Tintazul commented 10 years ago

requires_wordpress_version() is not doing its job:

  1. After activation, it gets called every time WordPress runs a page, and not just upon activation – tested by adding an echo right when the function begins
  2. It's not really preventing the plugin from running if the version is too low – tested with "4.3" in if ( version_compare($wp_version, "4.3", "<" ) ) {

I'll try to come up with a patch.

Tintazul commented 10 years ago

Newsflash! Number 1 above is not a bug; this guy says, “The upgrader check can still remain in the init function, a user might have not deactivated the plugin before uploading the new files.”

Tintazul commented 10 years ago

I have a bug fix for Number 2 above, will push as 0.2.2 screenshot-plugin-not-activated