search

JopStro / bspswallow

dwm-like swallowing for bspwm
MIT License
126 stars 12 forks source link

noswallow file gets ignored #19

Open jiampong212 opened 2 years ago

jiampong212 commented 2 years ago

i have xev in my no swallow file but it still gets swallowed. tried adding sxiv to test and sxiv also gets swallowed. seems to me like the noswallow files gets ignored

cottnn commented 2 years ago

Somewhat late, but this is what worked for me. Replace this line (currently line 38):

grep -q "^$(get_class "$swallowerid")$" ~/.config/bspwm/{noswallow, terminals} && return

with this line:

grep -q "^$(get_class "$swallowerid")$" ~/.config/bspwm/noswallow ~/.config/bspwm/terminals && return

Explanation: the script is trying to use some sort of syntactic extension by specifying ~/.config/bspwm/{noswallow,terminals} as a file to grep, which should be expanded by a shell into two separate paths. However, this seems to be a feature of a fish shell (?), whereas the script uses /bin/sh. On most systems, /bin/sh doesn't have this feature (mine is a symlink to dash).