Jopp-gh / Obsidian-Dune84

Obsidian theme
GNU General Public License v2.0
29 stars 1 forks source link

Render issues on windows #16

Closed kodikos closed 3 months ago

kodikos commented 3 months ago

I'm on Windows 11, monitor res of 2560x1440 with 100% scaling. Obisidian v1.5.3. Dune v2.5.4. I wanted to try this theme after seeing you had fixed mermaid embeds. You have at that! However, I had a number of other issues, hopefully the screenshot is enough to give you an idea of what I found:

202401-Dune-win-bugs

Jopp-gh commented 3 months ago

The left ribbon doesn't appear at all.

Did you install the Style Settings plugin ? If so, the left ribbon should be visible by default.

Top-left file browser collapse button doesn't work

Do you mean in full screen mode or in window mode ? In full screen this button is a bit buggy but should work. Anyway, I'll put it on my to do list. In window mode this button should work just fine.

Size of the top window title-bar is vertically (..)

This issue happens on Windows computers, maybe on Linux as well. In the next update slim bars will be optional. Meanwhile, you can revert to Default values if you open Obsidian's "Setting>Style Settings>Dune>Show Ui elements>slim bars"

Thanks for your report!

kodikos commented 3 months ago

Did you install the Style Settings plugin ?

Yes, it is installed. The other plugins I have installed are: Outliner, Iconize, Table of Contents, Emoji Shortcodes and Callout Manager.

Edit: Just to make sure I tried it in a fresh vault without plugins, installed style settings first then the dune theme. Nothing else set.

Top-left file browser collapse button doesn't work Do you mean in full screen mode or in window mode ?

Window and full screen modes

Jopp-gh commented 3 months ago

Tonight I'll upload an update. Meanwhile, try to activate 2 toggle buttons:

please see the attachment below, (blue buttons) Obs-default-gui

kodikos commented 3 months ago

That's part of the problem.. I don't think I can reach those options at the moment, unless there's some way to get to the settings without the left toolbar, but that's the only way I know 🤷‍♀️

Jopp-gh commented 3 months ago

Ooops, sorry! I take note and will add your scenario to my troubleshooting guide. In addition I'll change settings for my update tonight

Solution Just open the command palette with Ctrl+P and type settings to open Obsidians settings. The full command is called "open settings". Inside setting, look for community plugins and then click on Style Settings. Enter in Dune>show ui elements>main window and activate

kodikos commented 3 months ago

Ahh.. thanks for that.. and it highlighted the problem that I was having.. although installed, I hadn't actually enabled Style Settings 🤦‍♀️ The sidebar is back!

Jopp-gh commented 3 months ago

Regards the top-left sidebar button.

Placing that button isn't simple, on Mac the default placement is pretty bad - on the top-left, after the window management buttons (close, collapse, zoom).

Right now, you can avoid issues with this button if you keep the sidebar / ribbon activated. I will try to find a definitive fix, meanwhile you may open Settings>Hotkeys, search for toggle left sidebar and assign a keyboard shortcut like, ctrl+shift+left arrow

Best thing would be to remove those window management buttons (close, collapse, zoom) altogether to have more space for Obsidian, but that's not possible with css.

Let me know if my last update helped you a bit. Double-check and if everything is ok, you can close this bug report as completed.

kodikos commented 3 months ago

Regards the top-left sidebar button.

So now, when the side ribbon and folder view are collapsed, it's doing this: image It is clickable and does open the folder view, which then makes it unclickable. If the side ribbon is showing, as you say, it's working correctly all the time. It's fine for my purposes, I leave it on all the time.

I'm quite happy to close, this is more for your info/debugging at this point. Thanks again!

Jopp-gh commented 3 months ago

Hmm this looks really bad ! I did not expect to see this on Windows. On Mac, everything looks normal. Well, it does not matter, I will find an acceptable solution for you too.

Jopp-gh commented 3 months ago

A quick fix is ready!

  1. download the attachment
  2. navigate to your Obsidian vault on disk, (use your file explorer, not Obsidian)
  3. reveal hidden items to find the hidden folder ".obsidian" inside your vault folder
  4. go to ".obsidian>themes>Dune>" and replace - overwrite "theme.css" using the unzipped file

this should revert your sidebar button to default values. Let me know if this fix works for you, so I can think how to fix the same button for Mac users as well, thanks.

theme.css.zip

Jopp-gh commented 3 months ago

could you please install and activate the attachment below and report back ? Here a quick guide how to install css snippets If it does nothing, then I can add this fix for my Mac users.

sidebar-btn.css.zip

kodikos commented 3 months ago

Okay, with the new theme.css you sent through, it's back to where it was, but it doesn't work again unless the sidebar is open. image If I add the sidebar-btn.css snippet, it doesn't change the behaviour, AFAICS.

Jopp-gh commented 3 months ago

thanks for checking!

Basically, I restored the sidebar button to Obsidian's default values, I removed any change made to it.

Great news! nice to hear my snippet does nothing on your system, so I can integrate this fix for my Mac Os users.

Right now I don't have much time to research a custom placement for the sidebar button, but you are right, if the left ribbon is hidden the sidebar button becomes unresponsive

and what happens on Windows? is the sidebar button unresponsive only in window or only in fullscreen mode or both modes?

kodikos commented 3 months ago

Both modes.

Jopp-gh commented 3 months ago

Hi, could you please try out, if my update improves your sidebar button ?

on Mac, the sidebar button works in:

cursor-placement-left ribbon-hidden

theme.css.zip

kodikos commented 3 months ago

I'm not observing any difference in behaviour.

Jopp-gh commented 3 months ago

Hi, could you please try my older themes too? see: https://github.com/Jopp-gh/Obsidian-Dune84/releases

Jopp-gh commented 3 months ago

Unless the Obsidian dev team doesn't change code for the left ribbon, I don't see a way to implement a better and bug-free sidebar button.

My advice; just keep the left ribbon visible to avoid bugs. Btw, Dune obscures the icons of the left a lil bit, so you can work without distraction Closing as wontFix